Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446Ab0K3Dzu (ORCPT ); Mon, 29 Nov 2010 22:55:50 -0500 Received: from mail-qy0-f181.google.com ([209.85.216.181]:34351 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776Ab0K3Dzt convert rfc822-to-8bit (ORCPT ); Mon, 29 Nov 2010 22:55:49 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Eu71GuuIf/pgz4Dstyerpc2JkJODt1wKzI88aRVST1xAGzOInj+n2ESbnw1mE3BBee AgDtQMY5aEsYht1tWeUuloHn7OW8dqQtxbHu2tLNoDQFnqvkHZd7sGt3QKD2VXT3RSFo FFjqsBXAcgPn5Zfq9V8MmKRI3aNyY9pBY7FXU= MIME-Version: 1.0 In-Reply-To: <20101129103845.GA1195@localhost> References: <20101129103845.GA1195@localhost> Date: Tue, 30 Nov 2010 12:55:48 +0900 Message-ID: Subject: Re: [BUGFIX] vmstat: fix dirty threshold ordering From: Minchan Kim To: Wu Fengguang Cc: Andrew Morton , Michael Rubin , Linux Memory Management List , LKML Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 28 On Mon, Nov 29, 2010 at 7:38 PM, Wu Fengguang wrote: > The nr_dirty_[background_]threshold fields are misplaced before the > numa_* fields, and users will read strange values. > > This is the right order. Before patch, nr_dirty_background_threshold > will read as 0 (the value from numa_miss). > > ? ? ? ?numa_hit 128501 > ? ? ? ?numa_miss 0 > ? ? ? ?numa_foreign 0 > ? ? ? ?numa_interleave 7388 > ? ? ? ?numa_local 128501 > ? ? ? ?numa_other 0 > ? ? ? ?nr_dirty_threshold 144291 > ? ? ? ?nr_dirty_background_threshold 72145 > > Cc: Michael Rubin > Signed-off-by: Wu Fengguang Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/