Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753951Ab0K3HMj (ORCPT ); Tue, 30 Nov 2010 02:12:39 -0500 Received: from cantor.suse.de ([195.135.220.2]:38632 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179Ab0K3HMi (ORCPT ); Tue, 30 Nov 2010 02:12:38 -0500 Date: Tue, 30 Nov 2010 08:12:36 +0100 Message-ID: From: Takashi Iwai To: "Li, Yan I" Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , "Ding, Jian-feng" , "linux-kernel@vger.kernel.org" , "meego-kernel@lists.meego.com" , Christopher Heiny Subject: Re: [PATCH] Input: Lenovo S10-3t's touchpad support In-Reply-To: <20101130021833.GA8369@thyme.bj.intel.com> References: <20101127075528.GA28667@core.coreip.homeip.net> <20101130021833.GA8369@thyme.bj.intel.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1596 Lines: 44 At Tue, 30 Nov 2010 10:18:40 +0800, Li, Yan I wrote: > > On Sat, Nov 27, 2010 at 03:55:28PM +0800, Dmitry Torokhov wrote: > > > So far we've found that the S10-3ts are shipped with two slightly > > > different models of touchpads, of which the 0x0c cap is either > > > 0x5a0400 or 0x4a0500. They are not Clickpad and return BTN_LEFT and > > > BTN_RIGHT normally. > > > > Hmm, this is weird. According to my data: > > > > >> Treat it as a two-bit field. > > >> 0x00 == not a clickpad > > >> 0x01 == 1 button clickpad > > >> 0x02 == 2 button clickpad > > >> 0x03 == reserved > > Wait, you said there are "2 button clickpad"? If so the current way > the kernel handles clickpad is totally wrong: > > if (SYN_CAP_CLICKPAD(priv->ext_cap_0c)) { > /* Clickpads report only left button */ > __clear_bit(BTN_RIGHT, dev->keybit); > __clear_bit(BTN_MIDDLE, dev->keybit); > } > > It could only handle those "1 button clickpad", which emits solely > BTN_MIDDLE (and the kernel sends it out as BTN_LEFT instead). It can't > handle "2 button clickpad" correctly. The "normal" clickpad also reports that bit. I don't see any difference between Lenovo and HP machines wrt caps values. It shows the exact same numbers below: Synaptics Touchpad, model: 1, fw: 7.4, id: 0x1e0b1, caps: 0xd04771/0xe40000/0x5a0400 Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/