Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616Ab0K3QWN (ORCPT ); Tue, 30 Nov 2010 11:22:13 -0500 Received: from filtteri5.pp.htv.fi ([213.243.153.188]:45829 "EHLO filtteri5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab0K3QWM (ORCPT ); Tue, 30 Nov 2010 11:22:12 -0500 From: Alexander Shishkin To: linux-kernel@vger.kernel.org Cc: Alexander Shishkin , Stephen Hemminger , Andrew Morton , Michal Marek , WANG Cong Subject: [PATCH] headers_check: better search for functions in headers Date: Tue, 30 Nov 2010 18:21:59 +0200 Message-Id: <1291134119-12903-1-git-send-email-virtuoso@slind.org> X-Mailer: git-send-email 1.7.2.1.45.gb66c2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 38 Some headers don't bother with "extern" in function prototypes, which results in said prototypes being unnoticed and exported to userland. This patch slightly improves detection of such cases by checking for C type names as well in the beginning of a line. Signed-off-by: Alexander Shishkin CC: Stephen Hemminger CC: Andrew Morton CC: Michal Marek CC: WANG Cong CC: linux-kernel@vger.kernel.org --- scripts/headers_check.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 50d6cfd..e0e25a1 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -64,7 +64,7 @@ sub check_include sub check_declarations { - if ($line =~m/^\s*extern\b/) { + if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) { printf STDERR "$filename:$lineno: " . "userspace cannot call function or variable " . "defined in the kernel\n"; -- 1.7.2.1.45.gb66c2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/