Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756022Ab0K3STP (ORCPT ); Tue, 30 Nov 2010 13:19:15 -0500 Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:10497 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755759Ab0K3STN convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 13:19:13 -0500 From: Shreyas Bhatewara To: Joe Perches , "VMware, Inc." CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 30 Nov 2010 10:15:58 -0800 Subject: RE: [PATCH 47/62] vmxnet3: Use static const Thread-Topic: [PATCH 47/62] vmxnet3: Use static const Thread-Index: AcuJJXWU+st3yTG1RPKhrWlvlHZemQHlS2SM Message-ID: <89E2752CFA8EC044846EB8499819134102BD7E186D@EXCH-MBX-4.vmware.com> References: ,<76d2bd45fbde30f47992b99cf5014dbab4079882.1290305776.git.joe@perches.com> In-Reply-To: <76d2bd45fbde30f47992b99cf5014dbab4079882.1290305776.git.joe@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 47 Thanks Joe. Acked-by: Shreyas N Bhatewara Acked-by: Scott J. Goldman ________________________________________ From: Joe Perches [joe@perches.com] Sent: Saturday, November 20, 2010 6:38 PM To: Shreyas Bhatewara; VMware, Inc. Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH 47/62] vmxnet3: Use static const Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 38916 437 9160 48513 bd81 drivers/net/vmxnet3/vmxnet3_drv.o.new 38916 437 9160 48513 bd81 drivers/net/vmxnet3/vmxnet3_drv.o.old Signed-off-by: Joe Perches --- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 21314e0..31dc45a 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -1082,7 +1082,9 @@ static int vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, struct vmxnet3_adapter *adapter, int quota) { - static u32 rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; + static const u32 rxprod_reg[2] = { + VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2 + }; u32 num_rxd = 0; struct Vmxnet3_RxCompDesc *rcd; struct vmxnet3_rx_ctx *ctx = &rq->rx_ctx; -- 1.7.3.2.245.g03276.dirty-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/