Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756299Ab0K3T3P (ORCPT ); Tue, 30 Nov 2010 14:29:15 -0500 Received: from sous-sol.org ([216.99.217.87]:33052 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752433Ab0K3T3O (ORCPT ); Tue, 30 Nov 2010 14:29:14 -0500 Date: Tue, 30 Nov 2010 11:28:45 -0800 From: Chris Wright To: Suresh Siddha Cc: Chris Wright , Kenji Kaneshige , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "indou.takao@jp.fujitsu.com" Subject: Re: [PATCH 0/2] Fix dmar fault interrupt problems Message-ID: <20101130192845.GI10050@sequoia.sous-sol.org> References: <4CF4B597.4030708@jp.fujitsu.com> <1291140553.2623.10.camel@sbsiddha-MOBL3> <20101130181314.GH10050@sequoia.sous-sol.org> <1291141220.2623.13.camel@sbsiddha-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291141220.2623.13.camel@sbsiddha-MOBL3> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 44 * Suresh Siddha (suresh.b.siddha@intel.com) wrote: > On Tue, 2010-11-30 at 10:13 -0800, Chris Wright wrote: > > * Suresh Siddha (suresh.b.siddha@intel.com) wrote: > > > On Tue, 2010-11-30 at 00:28 -0800, Kenji Kaneshige wrote: > > > > Hi, > > > > > > > > Here are patches to fix the following problems regarding dmar fault interrupt. > > > > > > > > - No dmar fault event is notified in x2apic cluster mode > > > > - Changing IRQ affinity of dmar fault interrupt causes "No irq handler > > > > for vector (irq XX)" message and dmar fault interrupts are never > > > > notified after that. > > > > > > Kenji, In addition to these two, there are couple of more patches that > > > are needed to fix the kexec/kdump issue that we are debugging on RH > > > bugzilla. > > > > > > I will post all these 4 patches shortly. I already noticed and queued > > > the second patch (dmar irq migration) you mentioned. > > > > And one of them (the additional call to flushing existing dmar faults) > > is not needed. > > yes, that patch is not needed for the current kexec/kdump issue. But > nevertheless that is an issue that needs to be addressed aswell. AFAICT, it just becomes a duplicate call in a narrow window. native_smp_prepare_cpus() (or APIC_init_uniprocessor()): enable_IR_x2apic() enable_IR() enable_intr_remapping() <-- clears faults default_setup_apic_routing() enable_drhd_fault_handling() <-- added call to clear faults That's what I meant by not needed. thanks, -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/