Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512Ab0K3WLJ (ORCPT ); Tue, 30 Nov 2010 17:11:09 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40832 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475Ab0K3WLG (ORCPT ); Tue, 30 Nov 2010 17:11:06 -0500 MIME-Version: 1.0 In-Reply-To: <1291138954-10310-1-git-send-email-Trond.Myklebust@netapp.com> References: <1291138954-10310-1-git-send-email-Trond.Myklebust@netapp.com> From: Linus Torvalds Date: Tue, 30 Nov 2010 14:10:44 -0800 Message-ID: Subject: Re: [PATCH] NFS: Fix a readdirplus bug To: Trond Myklebust Cc: Linux Kernel Mailing List , linux-nfs@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 16 On Tue, Nov 30, 2010 at 9:42 AM, Trond Myklebust wrote: > > When comparing filehandles in the helper nfs_same_file(), we should not be > using 'strncmp()': filehandles are not null terminated strings. Hmm. Applied, but sadly Nick Bowler reports that it doesn't actually fix his problem, so there is still a serious regression there. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/