Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753778Ab0K3WNd (ORCPT ); Tue, 30 Nov 2010 17:13:33 -0500 Received: from mx2.netapp.com ([216.240.18.37]:50535 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603Ab0K3WNc convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 17:13:32 -0500 X-IronPort-AV: E=Sophos;i="4.59,282,1288594800"; d="scan'208";a="489180551" Subject: Re: [PATCH] NFS: Fix a readdirplus bug From: Trond Myklebust To: Linus Torvalds Cc: Linux Kernel Mailing List , linux-nfs@vger.kernel.org In-Reply-To: References: <1291138954-10310-1-git-send-email-Trond.Myklebust@netapp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Organization: NetApp Inc Date: Tue, 30 Nov 2010 17:13:24 -0500 Message-ID: <1291155204.2998.31.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14) X-OriginalArrivalTime: 30 Nov 2010 22:13:31.0706 (UTC) FILETIME=[D2AE31A0:01CB90DB] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 28 On Tue, 2010-11-30 at 14:10 -0800, Linus Torvalds wrote: > On Tue, Nov 30, 2010 at 9:42 AM, Trond Myklebust > wrote: > > > > When comparing filehandles in the helper nfs_same_file(), we should not be > > using 'strncmp()': filehandles are not null terminated strings. > > Hmm. Applied, but sadly Nick Bowler reports > that it doesn't actually fix his problem, so there is still a serious > regression there. > > Linus OK. I'll follow up that problem with him. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/