Date: Tue, 30 Nov 2010 14:20:39 -0800
From: Chris Wright <chrisw@sous-sol.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
        Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>, "hpa@zytor.com" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "indou.takao@jp.fujitsu.com" <indou.takao@jp.fujitsu.com>
Subject: Re: [PATCH 0/2] Fix dmar fault interrupt problems
Message-ID: <20101130222039.GJ10050@sequoia.sous-sol.org>
References: <4CF4B597.4030708@jp.fujitsu.com>
 <1291140553.2623.10.camel@sbsiddha-MOBL3>
 <20101130181314.GH10050@sequoia.sous-sol.org>
 <1291141220.2623.13.camel@sbsiddha-MOBL3>
 <20101130192845.GI10050@sequoia.sous-sol.org>
 <1291146762.2623.34.camel@sbsiddha-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1291146762.2623.34.camel@sbsiddha-MOBL3>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1601
Lines: 47

* Suresh Siddha (suresh.b.siddha@intel.com) wrote:
> On Tue, 2010-11-30 at 11:28 -0800, Chris Wright wrote:
> > AFAICT, it just becomes a duplicate call in a narrow window.
> > 
> > native_smp_prepare_cpus() (or APIC_init_uniprocessor()):
> >  enable_IR_x2apic()
> >   enable_IR()
> >    enable_intr_remapping() <-- clears faults
> >  default_setup_apic_routing()
> >    enable_drhd_fault_handling() <-- added call to clear faults
> > 
> > That's what I meant by not needed.
> 
> I agree that we will call clear faults twice.
> 
> With out the second clear fault, any fault in that narrow window of
> enabling intr-remapping and enabling fault handling will go unnoticed
> and block further faults getting reported.
> 
> I am not sure if the first fault is necessary. I can check and remove it
> if not needed.
> 
> Ideally we want to do something like:
> 
> Setup fault handling
> Clear any faults
> Enable intr-remapping

Agree, that's ideal.

> But fault handling interrupt configuration depends on the apic mode that
> gets selected based on whether intr-remapping was enabled successfully
> or not. And hence we were enabling fault handling after enabling the
> intr-remapping mode.
> 
> I can see if I can cleanup any of these flows for 2.6.38. For 2.6.37 and
> older kernels I would like to keep the patch simple.

Yup, makes sense.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/