Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588Ab0LADjx (ORCPT ); Tue, 30 Nov 2010 22:39:53 -0500 Received: from smtp-out.google.com ([74.125.121.35]:21700 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754379Ab0LADjv (ORCPT ); Tue, 30 Nov 2010 22:39:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=message-id:date:from:user-agent:mime-version:newsgroups:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; b=YtubH4iaunBC7Tk5nTcy31dJEp9gO1BxlbDZp0RW9wlP2bw5C6XpRe5PPukUIH5vAt O6rn5gQuiT/hkA0sUlgA== Message-ID: <4CF5C379.8030204@google.com> Date: Tue, 30 Nov 2010 19:39:37 -0800 From: Paul Turner User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel To: Mike Galbraith CC: Ingo Molnar , Oleg Nesterov , Peter Zijlstra , Linus Torvalds , LKML Subject: Re: [PATCH v4] sched: automated per session task groups References: <20101121133744.GA10765@elte.hu> <1290700829.4759.16.camel@maggy.simson.net> <1290954299.30515.15.camel@marge.simson.net> In-Reply-To: <1290954299.30515.15.camel@marge.simson.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2155 Lines: 64 On 11/28/10 06:24, Mike Galbraith wrote: > On Thu, 2010-11-25 at 09:00 -0700, Mike Galbraith wrote: > >> My vacation is (sniff) over, so I won't get a fully tested patch out the >> door for review until I get back home. > > Either I forgot to pack my eyeballs, or laptop is just too dinky and > annoying. Now back home on beloved box, this little bugger poked me > dead in the eye. > > Something else is seriously wrong though. 36.1 with attached (plus > sched, cgroup: Fixup broken cgroup movement) works a treat, whereas > 37.git and tip with fixlet below both suck rocks. With a make -j40 > running, wakeup-latency is showing latencies of>100ms, amarok skips, > mouse lurches badly.. generally horrid. Something went south. > I'm looking at this. The share:share ratios looked good in static testing, but perhaps we need a little more wake-up boost to improve interactivity. Should have something tomorrow. - Paul > sched: fix 3d4b47b4 typo. > > Signed-off-by: Mike Galbraith > Cc: Peter Zijlstra > Cc: Ingo Molnar > LKML-Reference: new submission > --- > kernel/sched.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux-2.6/kernel/sched.c > =================================================================== > --- linux-2.6.orig/kernel/sched.c > +++ linux-2.6/kernel/sched.c > @@ -8087,7 +8087,6 @@ static inline void unregister_fair_sched > { > struct rq *rq = cpu_rq(cpu); > unsigned long flags; > - int i; > > /* > * Only empty task groups can be destroyed; so we can speculatively > @@ -8097,7 +8096,7 @@ static inline void unregister_fair_sched > return; > > raw_spin_lock_irqsave(&rq->lock, flags); > - list_del_leaf_cfs_rq(tg->cfs_rq[i]); > + list_del_leaf_cfs_rq(tg->cfs_rq[cpu]); > raw_spin_unlock_irqrestore(&rq->lock, flags); > } > #else /* !CONFG_FAIR_GROUP_SCHED */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/