Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610Ab0LAGEW (ORCPT ); Wed, 1 Dec 2010 01:04:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:32988 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902Ab0LAGEV (ORCPT ); Wed, 1 Dec 2010 01:04:21 -0500 Date: Wed, 01 Dec 2010 07:04:19 +0100 Message-ID: From: Takashi Iwai To: "Li, Yan I" Cc: Tobyn Bertram , "'Dmitry Torokhov'" , "linux-input@vger.kernel.org" , "Ding, Jian-feng" , "linux-kernel@vger.kernel.org" , "meego-kernel@lists.meego.com" Subject: Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad In-Reply-To: <20101201041102.GC3411@thyme.bj.intel.com> References: <20101130075026.GA15731@core.coreip.homeip.net> <20101130080759.GA17830@thyme.bj.intel.com> <20101201041102.GC3411@thyme.bj.intel.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 32 At Wed, 1 Dec 2010 12:11:04 +0800, Li, Yan I wrote: > > On Tue, Nov 30, 2010 at 11:48:12PM +0800, Tobyn Bertram wrote: > > I do not have a S10-3t. I have a HP DV7t with a standard 1 button Clickpad. > > I am sorry for any confusion. > > Thank you. This clarify the S10-3t touchpad mystery. So I think my v2 > patch is valid. > > > I think that 2 different Clickpads will need to be defined: 1 button > > Clickpads and 2 button Clickpads. Maybe like this? > > > > #define SYN_CAP_CLICKPAD1BTN(ex0c) ((ex0c) & 0x100000) > > #define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) & 0x000100) > > Maybe, although we don't have any code that needs > SYN_CAP_CLICKPAD2BTN() so far, only 1-button clickpad needs special > handling, but it's good to have a more precise name. Agreed. Also, it's interesting to see how 2-button clickpad devices behave in multi-touch mode... thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/