MIME-Version: 1.0
In-Reply-To: <1291147139-23472-1-git-send-email-davidsin@ti.com>
References: <1291147139-23472-1-git-send-email-davidsin@ti.com>
From: "Varadarajan, Charulatha" <charu@ti.com>
Date: Wed, 1 Dec 2010 12:17:22 +0530
Message-ID: <AANLkTi=39XEC9ie=bAapymAtx6k+ej49N5B1+_gfRhmE@mail.gmail.com>
Subject: Re: [RFC v2 0/8] TI DMM-TILER driver
To: David Sin <davidsin@ti.com>
Cc: Greg KH <greg@kroah.com>, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 7521
Lines: 166

On Wed, Dec 1, 2010 at 01:28, David Sin <davidsin@ti.com> wrote:
> Tiling and Isometric Lightweight Engine for Rotation (TILER) driver
>
> Dynamic Memory Manager (DMM) is a hardware block made by Texas Instruments.
> Within the DMM exists at least one TILER hardware component. ?Its purpose is to
> organize video/image memory in a 2-dimensional fashion to limit memory
> bandwidth and facilitate 0 effort rotation and mirroring. ?The TILER driver
> facilitates allocating, freeing, as well as mapping 2D blocks (areas) in the
> TILER container(s). ?It also facilitates rotating and mirroring the allocated
> blocks or its rectangular subsections.
>
> TERMINOLOGY
>
> "slot"
>
> The basic TILER driver operates on blocks of slots. ?A slot is the granularity
> of the TILER hardware device. ?For all current uses it is 4K, but could also be
> 16 or 64K. ?The DMM-TILER TRM refers to this as "page" but we want to separate
> this concept from the MMU pages.
>
> "page"
>
> The granularity of the MMU, used by the kernel. ?This is 4K.
>
> "block"
>
> The TILER hardware component supports 1D and 2D blocks. ?A 2D block is a
> rectangular arrangement of slots with arbitrary width and height in a 2D
> container. ?A 1D block is a linear arrangement of slots with arbitrary length
> ?in a 1D container. ?This TILER driver only supports 2D blocks.
>
> "container"
>
> The TILER driver supports an arbitrary TILER container size. ?However, for
> all current implementations it is 256 by 128 slots. ?The container currently can
> only be used as a 2D container.
>
> "reserved area"
>
> Each block resides within a reserved area in the container. ?This area may
> be larger than the actual set of slots that a block occupies. ?The reason for
> this is to protect access from one block into another. ?Since TILER container is
> mmap-ped into user space as individual pages, all slots that are spanned by
> that page become visible to the user. ?The tiler driver allows restricting the
> granularity of the reserved area (default alignment) as well as the mapped
> area (granularity).
>
> Changes made from RFC v1: http://www.spinics.net/lists/linux-omap/msg33867.html
>
> Santosh Shilimkar:
> 1) Correct documentation location
> 2) Remove ioremap of RAM
> 3) Implement probe function and hwmod
> 4) Correct commenting style
> 5) Reduce use of barrier instances
>
> Linus Walleij:
> 1) Define TCM acryonym
>
> Russell King:
> 1) Implement probe function
> 2) Fix spelling mistake
> 3) Remove GFP_ATOMIC flag when calling dma_alloc_coherent for PAT array mem
> 4) Replace alloc_page and flush range calls with dma_alloc_coherent
>
> Nishanth Menon:
> 1) Address infinite while loop when reading dmm register
>
> Benoit Cousson:
> 1) Fix source file headers
> 2) Correct logical errors in device file
>
> Kevin Hilman:
> 1) Move DMM/TILER source code into driver/misc/tiler until a recommendation
> is made as to where it should go
>
> List of pending items in proposed order:
>
> * Determine driver source code location
> ?(Currently, resides in drivers/misc/tiler)
> * Add area packing support (multiple blocks can reside in the same band/area)
> ?to optimize area use
> * Add group-ID support (to specify which blocks can reside together in the
> ?same area)
> * Add multiple search directions to TCM-SiTA
> * Add 1D block support (including adding 1D search algo to TCM-SiTA)
> * Optimize mutex handling (don.t hold mutex during memory
> ?allocation/mapping/cache flushing)
> * Add block reference counting, support for sharing blocks
> * Move all kernel-API-s to tiler-iface.c
> * Support orphaned block support (in preparation for process cleanup support)
> * Change block identification from physical address to key-ID pair
> ?(in preparation for user space support, and process security)
> * Add support for process security (blocks from separate processes never
> ?reside in the same band)
> * Support file interface (ioctl and mmap)
> * Support for buffers (ordered list of blocks that are mapped to userspace
> ?together, such as YUV420sp)
> * Support 1D user buffer mapping into TILER container
> * Support for block pre-reservation (to further optimize area use)
>
> David Sin (1):
> ?TILER-DMM: DMM-PAT driver for TI TILER
>
> Lajos Molnar (6):
> ?TILER-DMM: Container manager interface and utility definitons
> ?TILER-DMM: TILER Memory Manager interface and implementation
> ?TILER-DMM: TILER interface file and documentation
> ?TILER-DMM: Geometry and view manipulation functions
> ?TILER-DMM: Main TILER driver implementation
> ?TILER-DMM: Linking TILER driver into the Linux kernel build
>
> Ravi Ramachandra (1):
> ?TILER-DMM: Sample TCM implementation: Simple TILER Allocator (SiTA)
>
> ?Documentation/arm/OMAP/TILER ? ? ? ? ? ? | ?126 +++++++++
> ?arch/arm/mach-omap2/Makefile ? ? ? ? ? ? | ? ?1 +
> ?arch/arm/mach-omap2/dmm-omap44xx.c ? ? ? | ? 81 ++++++
> ?arch/arm/mach-omap2/include/mach/dmm.h ? | ? 92 +++++++
> ?arch/arm/mach-omap2/include/mach/tiler.h | ?173 ++++++++++++
> ?drivers/misc/Kconfig ? ? ? ? ? ? ? ? ? ? | ? ?5 +
> ?drivers/misc/Makefile ? ? ? ? ? ? ? ? ? ?| ? ?1 +
> ?drivers/misc/tiler/Kconfig ? ? ? ? ? ? ? | ? 72 +++++
> ?drivers/misc/tiler/Makefile ? ? ? ? ? ? ?| ? ?7 +
> ?drivers/misc/tiler/_tiler.h ? ? ? ? ? ? ?| ? 48 ++++
> ?drivers/misc/tiler/dmm-main.c ? ? ? ? ? ?| ?187 +++++++++++++
> ?drivers/misc/tiler/tcm.h ? ? ? ? ? ? ? ? | ?171 ++++++++++++
> ?drivers/misc/tiler/tcm/Makefile ? ? ? ? ?| ? ?1 +
> ?drivers/misc/tiler/tcm/_tcm-sita.h ? ? ? | ? 61 +++++
> ?drivers/misc/tiler/tcm/tcm-sita.c ? ? ? ?| ?422 ++++++++++++++++++++++++++++++
> ?drivers/misc/tiler/tcm/tcm-sita.h ? ? ? ?| ? 28 ++
> ?drivers/misc/tiler/tcm/tcm-utils.h ? ? ? | ? 51 ++++
> ?drivers/misc/tiler/tiler-geom.c ? ? ? ? ?| ?362 +++++++++++++++++++++++++
> ?drivers/misc/tiler/tiler-iface.c ? ? ? ? | ? 66 +++++
> ?drivers/misc/tiler/tiler-main.c ? ? ? ? ?| ?405 ++++++++++++++++++++++++++++
> ?drivers/misc/tiler/tmm-pat.c ? ? ? ? ? ? | ?266 +++++++++++++++++++
> ?drivers/misc/tiler/tmm.h ? ? ? ? ? ? ? ? | ?103 ++++++++
> ?22 files changed, 2729 insertions(+), 0 deletions(-)
> ?create mode 100644 Documentation/arm/OMAP/TILER
> ?create mode 100644 arch/arm/mach-omap2/dmm-omap44xx.c
> ?create mode 100644 arch/arm/mach-omap2/include/mach/dmm.h
> ?create mode 100644 arch/arm/mach-omap2/include/mach/tiler.h
> ?create mode 100644 drivers/misc/tiler/Kconfig
> ?create mode 100644 drivers/misc/tiler/Makefile
> ?create mode 100644 drivers/misc/tiler/_tiler.h
> ?create mode 100644 drivers/misc/tiler/dmm-main.c
> ?create mode 100644 drivers/misc/tiler/tcm.h
> ?create mode 100644 drivers/misc/tiler/tcm/Makefile
> ?create mode 100644 drivers/misc/tiler/tcm/_tcm-sita.h
> ?create mode 100644 drivers/misc/tiler/tcm/tcm-sita.c
> ?create mode 100644 drivers/misc/tiler/tcm/tcm-sita.h
> ?create mode 100644 drivers/misc/tiler/tcm/tcm-utils.h
> ?create mode 100644 drivers/misc/tiler/tiler-geom.c
> ?create mode 100644 drivers/misc/tiler/tiler-iface.c
> ?create mode 100644 drivers/misc/tiler/tiler-main.c
> ?create mode 100644 drivers/misc/tiler/tmm-pat.c
> ?create mode 100644 drivers/misc/tiler/tmm.h

The dmm driver is making use of omap_hwmod fw. But I could not see a patch
to add  dmm hwmod data to omap4 hwmod base in this series. Is this patch series
tested?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/