Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442Ab0LAHWk (ORCPT ); Wed, 1 Dec 2010 02:22:40 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:60428 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260Ab0LAHWi (ORCPT ); Wed, 1 Dec 2010 02:22:38 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6183"; a="64797708" Message-ID: <4CF5F7BA.7070909@codeaurora.org> Date: Wed, 01 Dec 2010 12:52:34 +0530 From: Trilok Soni User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Kevin McNeely CC: Henrik Rydberg , Dmitry Torokhov , David Brown , Samuel Ortiz , Eric Miao , Simtec Linux Team , Luotao Fu , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] touchscreen: Cypress TTSP G3 MTDEV Core Driver References: <1289327120-2612-1-git-send-email-kev@cypress.com> <4CE163CC.1060202@euromail.se> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 60 Hi Henrik, On 11/19/2010 11:09 PM, Kevin McNeely wrote: > Hello Henrik, > > Thank you for reviewing this code submission. > > I have replied to each of your comments below. > > I would like to resubmit to include the changes. > > Thanks and best regards, > Kevin > > >> -----Original Message----- >> From: Henrik Rydberg [mailto:rydberg@euromail.se] >> Sent: Monday, November 15, 2010 8:46 AM >> To: Kevin McNeely >> Cc: Dmitry Torokhov; David Brown; Trilok Soni; Samuel Ortiz; Eric > Miao; >> Simtec Linux Team; Luotao Fu; linux-input@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH] touchscreen: Cypress TTSP G3 MTDEV Core Driver >> >> On 11/09/2010 07:25 PM, Kevin McNeely wrote: >> >>> Initial release of Cypress TTSP Gen3 Core Driver. >>> Core Driver includes platform data definition file, >>> core driver definition file, and core touchscreen >>> touch handling of device data. Generates >>> multi-touch input events. >>> >>> Signed-off-by: Kevin McNeely >> >>> --- >> >> >> Thanks for your submission. Please find comments on MT inline. On a >> general >> note, it is strongly recommended that this driver be converted to the >> MT slots >> (type B) protocol. > > I will resubmit with Protocol A only at this time. I will remove the > Tracking ID's. > Any comments on this? ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/