Date: Wed, 1 Dec 2010 09:07:32 +0100
From: Francois Romieu <romieu@fr.zoreil.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH] net/r8169: Remove the firmware of RTL8111D
Message-ID: <20101201080732.GA3234@electric-eye.fr.zoreil.com>
References: <1291180966-3124-1-git-send-email-hayeswang@realtek.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1291180966-3124-1-git-send-email-hayeswang@realtek.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1361
Lines: 43

Hayes Wang <hayeswang@realtek.com> :
> Remove the firmware of RTL8111D from the kernel.
> The binary file of firmware would be moved to linux-firmware repository.

The driver can not simply go along when request_firmware fails. Though Ben's
code did not take care of it, the driver should imho propagate some return
code. Ben ?

There is no change in rtl8168d_3_hw_phy_config : could you add a comment
so that people know it is different ?

Could you Cc: the linux-firmware patch as well ?

Minor nit: please keep the code free of capitalized hex data.

> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 7d33ef4..cad1ba8 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
[...]
> @@ -1383,6 +1384,28 @@ static void rtl_phy_write(void __iomem *ioaddr, const struct phy_reg *regs, int
>  	}
>  }
>  
> +static void rtl_phy_write_fw(void __iomem *ioaddr, const struct firmware *fw)
> +{
[...]
> +		default:
> +			printk(KERN_WARNING "%s: Unknown action\n",
> +				__FUNCTION__);

A bit old school. It gives no information about the device.
Use netif_{err/info} or such ?

Thanks.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/