Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755307Ab0LANml (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Dec 2010 08:42:41 -0500
Received: from mail-ey0-f174.google.com ([209.85.215.174]:59916 "EHLO
	mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754182Ab0LANmk convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Dec 2010 08:42:40 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=ruKu9M9jbcQS2ZuqinTqaNJ7ifmH7rziMQWtduQC6WIEtj+68nqG+cRqTEGteL5dx6
         h2m0w8hb0lk6rfZDueVTEHDteoMuLfb8Xly/fbrOzCvH2HEWeSbBzg+j9n4UxpZs7P/0
         Ax4JY3vHoVsBS/n0S+YpDSowmjoSmVlCykaXw=
MIME-Version: 1.0
In-Reply-To: <AANLkTin6J1RiEvnKzzCPZtZpw=xBpBB=dhkpRFGjA0vo@mail.gmail.com>
References: <AANLkTimewZ4QhxzL2vOYYV85pegy8Fu6Rb4XUAPqGUXS@mail.gmail.com>
 <AANLkTinpX0p8hv_RJojASbjDNYQ60bODo3kLBobRDtmf@mail.gmail.com> <AANLkTin6J1RiEvnKzzCPZtZpw=xBpBB=dhkpRFGjA0vo@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Wed, 1 Dec 2010 21:42:18 +0800
Message-ID: <AANLkTim2M4LR3gy=HM2hRBBSv+b-oGeCeE8ZEe6m6wrP@mail.gmail.com>
Subject: Re: [PATCH] Built kernel without -O2 option
To: =?ISO-8859-1?Q?Petr_Hluz=EDn?= <petr.hluzin@gmail.com>
Cc: Arnaud Lacombe <lacombar@gmail.com>, linux-kernel@vger.kernel.org,
        gdb@sourceware.org, hellogcc@freelists.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3456
Lines: 107

On Wed, Dec 1, 2010 at 06:40, Petr Hluz?n <petr.hluzin@gmail.com> wrote:
> On 29 November 2010 22:07, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> Hi,
>>
>> On Sun, Nov 28, 2010 at 10:56 PM, Hui Zhu <teawater@gmail.com> wrote:
>>> Hi,
>>>
>>> Now, there are a lot of ways to debug the Linux kernel with GDB, like
>>> qemu, kgtp or kgdb and so on.
>>> But the developer more like add a printk. It have a lot of reason, a big one is:
>>> (gdb) p ret
>>> $3 = <value optimized out>
>>> And the code execution order is not right.
>>>
>>> This is becuase the Kernel is bult with gcc -O2. ?Gcc will not
>>> generate enough debug message with file with -O2.
>>> So GDB cannot work very well with Linux kernel.
>>>
>>> So I make a patch that add a option in "Kernel hacking" called "Close
>>> GCC optimization". ?It will make kernel be built without -O2.
>>>
>> no, it does not, see below ..
>>
>>> I built and use it in i386 and x86_64. ?I will try to make it OK in other arch.
>>>
>>> And I will put new patch in here and
>>> http://code.google.com/p/kgtp/downloads/list
>>>
>>> Thanks,
>>> Hui
>>>
>>> Signed-off-by: Hui Zhu <teawater@gmail.com>
>>> ---
>>> [...]
>>> +ifdef CONFIG_CC_CLOSE_OPTIMIZATION
>>> +CFLAGS_process_$(BITS).o ? ? ? += -O2
>>> +CFLAGS_entry_$(BITS).o ? ? ? ? += -O2
>>> +CFLAGS_traps.o ? ? ? ? ? ? ? ? += -O2
>>> +CFLAGS_i387.o ? ? ? ? ? ? ? ? ?+= -O2
>>> +CFLAGS_xsave.o ? ? ? ? ? ? ? ? += -O2
>>> +CFLAGS_hpet.o ? ? ? ? ? ? ? ? ?+= -O2
>>> +endif
>>>
>>> [...]
>>>
>>> --- a/lib/Kconfig.debug
>>> +++ b/lib/Kconfig.debug
>>> @@ -136,6 +136,14 @@ config DEBUG_SECTION_MISMATCH
>>> ? ? ? ? ?- Enable verbose reporting from modpost to help solving
>>> ? ? ? ? ? ?the section mismatches reported.
>>>
>>> +config CC_CLOSE_OPTIMIZATION
>>> + ? ? ? bool "Close GCC optimization"
>>> + ? ? ? default n
>>> + ? ? ? help
>>> + ? ? ? ? Enabling this option will let gcc build kernel without "-O2".
>>> +
>>> + ? ? ? ? If unsure, say N.
>>> +
>> You are not consistent with yourself, you add an option saying "do not
>> build the kernel with -O2" and yet, you add "-O2" flags for unknown
>> reason all over the tree...
>
> The patch removes -O2 compilation flag from all files (see the
> fragment below) and adds the flag to the few files that actually need
> the flag. Unfortunately the patch does not explain that and the noise
> of adding the flag obscures the main thing.
>
>>> +++ b/Makefile
>>> @@ -540,8 +540,10 @@ all: vmlinux
>>> ?ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
>>> ?KBUILD_CFLAGS ?+= -Os
>>> ?else
>>> +ifndef CONFIG_CC_CLOSE_OPTIMIZATION
>>> ?KBUILD_CFLAGS ?+= -O2
>>> ?endif
>>> +endif
>
> Hui, The name of the config option is close to meaningless. I suggest:
>
> - config CONFIG_CC_CLOSE_OPTIMIZATION
> - ? ? ? bool "Close GCC optimization"
> + config CONFIG_CC_NO_OPTIMIZATION
> + ? ? ? bool "Compile with almost no optimization"
> ? ? ? ?default n
> ? ? ? ?help
> - ? ? ? ? ?Enabling this option will let gcc build kernel without "-O2".
> + ? ? ? ? ?Enabling this option will let gcc build kernel with no
> optimization (where possible).
> + ? ? ? ? ? This makes debugging friendlier.
>
>
> --
> Petr Hluzin
>

Thanks Petr.

I will fix them add try add some comments.

Thanks,
Hui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/