Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378Ab0LAO16 (ORCPT ); Wed, 1 Dec 2010 09:27:58 -0500 Received: from mail.perches.com ([173.55.12.10]:2043 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175Ab0LAO14 (ORCPT ); Wed, 1 Dec 2010 09:27:56 -0500 Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug From: Joe Perches To: "Luis R. Rodriguez" Cc: Felix Fietkau , linux-wireless , ath9k-devel@venema.h4ckr.net, peter@stuge.se, linux-kernel@vger.kernel.org In-Reply-To: References: <5febb0e1fba0ec2bb77f6ade8b251ba0edf4614c.1290988277.git.joe@perches.com> <20101129060732.5130.qmail@stuge.se> <4CF42C17.2070500@openwrt.org> <1291081185.16349.133.camel@Joe-Laptop> <4CF464D6.2020507@openwrt.org> <1291148375.18026.342.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Dec 2010 06:27:55 -0800 Message-ID: <1291213675.1845.12.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 26 On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote: > On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches wrote: > > Poor function naming is just that. > > It reduces readability and the uses are counter expectation. > The name is perfect, we use it to print anything, even non-debugging stuff. 'fraid not. ath/debug.h #ifdef CONFIG_ATH_DEBUG void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...) __attribute__ ((format (printf, 3, 4))); #else static inline void __attribute__ ((format (printf, 3, 4))) ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...) { } #endif /* CONFIG_ATH_DEBUG */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/