Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754079Ab0LAPP6 (ORCPT ); Wed, 1 Dec 2010 10:15:58 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:38711 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753385Ab0LAPP5 (ORCPT ); Wed, 1 Dec 2010 10:15:57 -0500 Date: Wed, 1 Dec 2010 10:15:54 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Linux-pm mailing list , LKML , Ming Lei Subject: Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily In-Reply-To: <201011302327.24222.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 23 On Tue, 30 Nov 2010, Rafael J. Wysocki wrote: > > Provided you repair the error that Lei Ming pointed out. That's the > > problem with functions that return Boolean values -- you have to name > > them very carefully. Ideally the name should be a predicate or a > > question. > > I already have fixed it. > > The name is unfortunate indeed, perhaps it's better to call that function > pm_new_wakeup_events() or something like this. Or pm_any_wakeup_events(). And reverse the meaning of the return value, of course -- it would be good to explain the return value in the kerneldoc. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/