Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524Ab0LARSK (ORCPT ); Wed, 1 Dec 2010 12:18:10 -0500 Received: from canuck.infradead.org ([134.117.69.58]:41086 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061Ab0LARSJ (ORCPT ); Wed, 1 Dec 2010 12:18:09 -0500 Date: Wed, 1 Dec 2010 12:18:01 -0500 From: Thomas Graf To: Eric Dumazet Cc: Amerigo Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org Subject: Re: [Patch] net: kill an RCU warning in inet_fill_link_af() Message-ID: <20101201171801.GA22009@canuck.infradead.org> Mail-Followup-To: Eric Dumazet , Amerigo Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org References: <1291202063-6239-1-git-send-email-amwang@redhat.com> <1291219386.2856.924.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291219386.2856.924.camel@edumazet-laptop> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 21 On Wed, Dec 01, 2010 at 05:03:06PM +0100, Eric Dumazet wrote: > [PATCH net-next-2.6] net: kill an RCU warning in inet_fill_link_af() > > commits 9f0f7272 (ipv4: AF_INET link address family) and cf7afbfeb8c > (rtnl: make link af-specific updates atomic) used incorrect > __in_dev_get_rcu() in RTNL protected contexts, triggering PROVE_RCU > warnings. > > Switch to __in_dev_get_rtnl(), wich is more appropriate, since we hold > RTNL. > > Based on a report and initial patch from Amerigo Wang. RTNL is not held while dumping, it is only held for get and set, but we still hold rcu readlocks while dumping so there should be no asserts triggered. Thanks for fixing this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/