Date: Wed, 1 Dec 2010 20:56:38 +0100
From: Pavel Machek <pavel@ucw.cz>
To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, gregkh@elf.ucw.cz
Subject: Re: [PATCH] add netdev led trigger
Message-ID: <20101201195638.GE15294@elf.ucw.cz>
References: <1289768305-1224-1-git-send-email-ecc@cmu.edu>
 <20101117105925.GC1574@ucw.cz>
 <20101117160919.GC10992@kroah.com>
 <20101117195843.GA31357@elf.ucw.cz>
 <20101117200614.GK15096@localhost>
 <20101130192053.GB5295@ucw.cz>
 <20101130232204.GF21496@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101130232204.GF21496@localhost>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 902
Lines: 31

Hi!

> > Please be consistent with rest of kernel...
> 
> There seem to be several ways this is done in existing sysfs drivers,
> and most aren't documented yet in Documentation/ABI.

Greg is official sysfs maintainer.

> 1. "0" and "1"

This should do the trick.

> 2. "enable" and "disable"
> 3. "enabled" and "disabled"
> 4. "enable" and "disable" when writing, but "enabled" and "disabled"
>     when read back
> 
> Some require trailing "\n", others make it optional.
> 
> Which is the One True Way?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/