Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755805Ab0LAWWi (ORCPT ); Wed, 1 Dec 2010 17:22:38 -0500 Received: from canuck.infradead.org ([134.117.69.58]:50440 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195Ab0LAWWh (ORCPT ); Wed, 1 Dec 2010 17:22:37 -0500 Date: Wed, 1 Dec 2010 17:22:33 -0500 From: Thomas Graf To: Eric Dumazet Cc: Amerigo Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org Subject: Re: [Patch] net: kill an RCU warning in inet_fill_link_af() Message-ID: <20101201222233.GB22009@canuck.infradead.org> Mail-Followup-To: Eric Dumazet , Amerigo Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org References: <1291202063-6239-1-git-send-email-amwang@redhat.com> <1291219386.2856.924.camel@edumazet-laptop> <20101201171801.GA22009@canuck.infradead.org> <1291224717.2856.1021.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291224717.2856.1021.camel@edumazet-laptop> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 15 On Wed, Dec 01, 2010 at 06:31:57PM +0100, Eric Dumazet wrote: > Are you sure RTNL is not held while dumping ? > > Patrick did the change to hold RTNL while dumping too, 3.5 years ago. > Check commits 6313c1e0992fea, 1c2d670f3660e9103 ([RTNETLINK]: Hold > rtnl_mutex during netlink dump callbacks) You are right, I only looked at netlink_dump_start() where the lock is released after setting ->cb. We grab RTNL again in netlink_dump() after allocating the skb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/