Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755928Ab0LBBnI (ORCPT ); Wed, 1 Dec 2010 20:43:08 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37310 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475Ab0LBBnH (ORCPT ); Wed, 1 Dec 2010 20:43:07 -0500 MIME-Version: 1.0 In-Reply-To: <20101201172224.b8a25bdf.akpm@linux-foundation.org> References: <1291217804-11257-1-git-send-email-Trond.Myklebust@netapp.com> <1291229669.6609.24.camel@heimdal.trondhjem.org> <1291234251.6609.39.camel@heimdal.trondhjem.org> <20101201123341.d12ef362.akpm@linux-foundation.org> <20101201133831.ea6ba10a.akpm@linux-foundation.org> <1291240272.6609.50.camel@heimdal.trondhjem.org> <20101201141351.8609140b.akpm@linux-foundation.org> <20101201143856.51f4f9d9.akpm@linux-foundation.org> <20101201153608.78b331f9.akpm@linux-foundation.org> <20101201172224.b8a25bdf.akpm@linux-foundation.org> From: Linus Torvalds Date: Wed, 1 Dec 2010 17:42:08 -0800 Message-ID: Subject: Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir To: Andrew Morton Cc: Trond Myklebust , Hugh Dickins , Nick Piggin , Nick Bowler , Linux Kernel Mailing List , linux-nfs@vger.kernel.org, Rik van Riel , Christoph Hellwig , Al Viro Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 19 On Wed, Dec 1, 2010 at 5:22 PM, Andrew Morton wrote: > > What we're talking about is races against memory reclaim, unmount, etc. Ahh. Those I can believe in. Although I think they'd almost incidentally be fixed by making inode freeing (which is where the 'struct address_space' is embedded) RCU-safe, which we're going to do anyway in 38. Then we could make the vmscan code just be a rcu-read section. Of course, I do think the race is basically impossible to hit in practice regardless. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/