Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567Ab0LBCKE (ORCPT ); Wed, 1 Dec 2010 21:10:04 -0500 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:56367 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755585Ab0LBCKB convert rfc822-to-8bit (ORCPT ); Wed, 1 Dec 2010 21:10:01 -0500 MIME-Version: 1.0 In-Reply-To: References: <1291147139-23472-1-git-send-email-davidsin@ti.com> <1291147139-23472-2-git-send-email-davidsin@ti.com> Date: Wed, 1 Dec 2010 20:10:00 -0600 Message-ID: Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER From: "Kanigeri, Hari" To: "Varadarajan, Charulatha" Cc: David Sin , Greg KH , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lajos Molnar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 29 On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha wrote: > David, > >> + ? ? ? ? ? ? ? if (!oh) >> + ? ? ? ? ? ? ? ? ? ? ? goto error; >> + >> + ? ? ? ? ? ? ? data->base = oh->_mpu_rt_va; > > not required. Make use of platform_get APIs in probe to extract the > base, dma and irq info using pdev. Not sure about using platform_get APIs. I think one has to use omap_hwmod_get_mpu_rt_va to get the address, which internally returns oh-<_mpu_rt_va. omap_hwmod_get_mpu_rt_va was added so that the individual drivers can avoid doing the ioremap. check the discussion regarding this. http://www.spinics.net/lists/linux-omap/msg33048.html Thank you, Best regards, Hari Kanigeri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/