Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757265Ab0LBGb5 (ORCPT ); Thu, 2 Dec 2010 01:31:57 -0500 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:41029 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756392Ab0LBGb4 (ORCPT ); Thu, 2 Dec 2010 01:31:56 -0500 Date: Thu, 2 Dec 2010 15:30:55 +0900 From: Paul Mundt To: David Rientjes Cc: Andrew Morton , Alex Bennee , Dave Hansen , linux-kernel@vger.kernel.org Subject: Re: [patch] flex_array: export symbols to modules Message-ID: <20101202063054.GB3367@linux-sh.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 31 On Wed, Dec 01, 2010 at 05:16:05PM -0800, David Rientjes wrote: > On Wed, 1 Dec 2010, Alex Bennee wrote: > > I want to be able to use the flex_array functions in my module so I > > wanted to EXPORT_SYMBOL the API. > > > > I added the appropriate EXPORT_SYMBOL runes into lib/flex_array.c and > > added externs in the header files but after re-building there is still > > no sign of them in Module.symvers. > > You shouldn't need to add any externs in include/linux/flex_array.h, they > should already be publically declared. > > Perhaps you forgot to include linux/module.h in lib/flex_array.c? > > flex_array: export symbols to modules > > Add EXPORT_SYMBOL() for all publically accessible flex array functions. > > Cc: Dave Hansen > Signed-off-by: David Rientjes > --- > lib/flex_array.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > This will be ineffective so long as flex_array.o remains lib-y. It will need to be moved to obj-y if modules are to also make use of it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/