Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757531Ab0LBLxh (ORCPT ); Thu, 2 Dec 2010 06:53:37 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48080 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757428Ab0LBLxf (ORCPT ); Thu, 2 Dec 2010 06:53:35 -0500 Date: Thu, 2 Dec 2010 12:53:30 +0100 From: Wolfram Sang To: Chuanxiao Dong Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, cjb@laptop.org, arjan@linux.intel.com, alan@linux.intel.com, akpm@linux-foundation.org, adrian.hunter@nokia.com Subject: Re: [PATCH v3 2/3]set timeout control reg for such SDHCI host Message-ID: <20101202115329.GE3345@pengutronix.de> References: <20101202112613.GC10358@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h56sxpGKRmy85csR" Content-Disposition: inline In-Reply-To: <20101202112613.GC10358@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:221:70ff:fe71:1890 X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 42 --h56sxpGKRmy85csR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote: > + if (host->quirks & SDHCI_QUIRK_FORCE_ERASE_SINGLE) { > + /* Set the timeout to be the maximum value */ > + if (cmd->erase_timeout) > + sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL); > + } > + > sdhci_writew(host, SDHCI_MAKE_CMD(cmd->opcode, flags), SDHCI_COMMAND); Hmm, this looks like another argument for Philip's idea to always use the maximum timeout value and skip the quirks related to it? --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --h56sxpGKRmy85csR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkz3iLkACgkQD27XaX1/VRsRFACgtNpV4S15ULJxkDjUn9Ck7VEJ AI8AoMVFkVEN1newoLQgPcbEUZrfTTIk =Uy3r -----END PGP SIGNATURE----- --h56sxpGKRmy85csR-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/