Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757864Ab0LBPTK (ORCPT ); Thu, 2 Dec 2010 10:19:10 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:51920 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757662Ab0LBPTI convert rfc822-to-8bit (ORCPT ); Thu, 2 Dec 2010 10:19:08 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=pk3EHwQg9n65AcQQI9J4fYrGOm87oX9aYRHOO3PuqOYjBuWgMN7gj+uEWTXg71WdXo HXeXyfQhH8xYGoc/WZY88iahd97mVV9y7mN3lc5yLOGJ5pEXktVABOROnfTcKAnko5mt r7fnW0FRUJHj2xLla00BkbWU7D61rnuPdx4Hc= MIME-Version: 1.0 In-Reply-To: <20101201002527.GC14383@n2100.arm.linux.org.uk> References: <20101130171626.GA6165@oksana.dev.rtsoft.ru> <20101130171658.GA24034@oksana.dev.rtsoft.ru> <20101130233204.GB14383@n2100.arm.linux.org.uk> <20101201002527.GC14383@n2100.arm.linux.org.uk> Date: Thu, 2 Dec 2010 15:19:05 +0000 X-Google-Sender-Auth: 1kNdglNgUAY7YUgCHzJFkUrjODw Message-ID: Subject: Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup From: Catalin Marinas To: Russell King - ARM Linux Cc: Anton Vorontsov , Kukjin Kim , Srinidhi Kasagar , Tony Lindgren , Jamie Iles , Colin Cross , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 23 On 1 December 2010 00:25, Russell King - ARM Linux wrote: > On Tue, Nov 30, 2010 at 11:32:04PM +0000, Russell King - ARM Linux wrote: >> Note that I'll go with factoring this out into arch/arm/kernel/smp_scu.c >> for the time being, but I'm not convinced about the other parts yet. > > IOW, something like the attached.  I've gone a little further and removed > the now unnecessary scu_enable() and scu_get_core_count() global functions, > making scu_enable() static, and eliminating scu_get_core_count() entirely. There is some benefit in leaving get_core_count() in the platform code. For example, the SCU on Cortex-A15 doesn't expose the core count register and we have to get it from somewhere else (for now from some L2 cache controller register but in the future it may be hardcoded, passed via FDT or simply trying to boot maxcpus). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/