Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758104Ab0LBVYQ (ORCPT ); Thu, 2 Dec 2010 16:24:16 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:46580 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757180Ab0LBVYP (ORCPT ); Thu, 2 Dec 2010 16:24:15 -0500 Date: Thu, 2 Dec 2010 16:23:46 -0500 From: Kyle McMartin To: Tejun Heo Cc: Kyle McMartin , Jeff Garzik , Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, LKML Subject: Re: [git patches] libata updates for 2.6.37 Message-ID: <20101202212346.GK25668@bombadil.infradead.org> References: <4CF52652.4030802@kernel.org> <20101130163150.GA25668@bombadil.infradead.org> <20101130175317.GB25668@bombadil.infradead.org> <20101130210938.GF25668@bombadil.infradead.org> <4CF62EE0.7040607@kernel.org> <20101201124445.GG25668@bombadil.infradead.org> <4CF6595A.6010104@kernel.org> <20101201155026.GH25668@bombadil.infradead.org> <20101201200907.GI25668@bombadil.infradead.org> <4CF77225.3040904@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CF77225.3040904@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6648 Lines: 124 On Thu, Dec 02, 2010 at 11:17:09AM +0100, Tejun Heo wrote: > Hmmm... something is setting EH_PENDING while EH is in progress. > Let's see what's doing it. Can you please apply the following patch > on top of the previous one and report the kernel log? > This gets triggered a bunch on boot-up: [ 36.981370] ata1: XXX SET EH PENDING, fastdrain=0 [ 36.981380] Pid: 0, comm: swapper Not tainted 2.6.37-0.rc4.git1.2.fc15.x86_64 #1 [ 36.981386] Call Trace: [ 36.981393] [] ata_eh_set_pending+0x3e/0x85 [ 36.981407] [] ata_do_link_abort+0x44/0x94 [ 36.981412] [] ata_port_abort+0x10/0x12 [ 36.981421] [] ahci_interrupt+0x467/0x5a1 [ 36.981428] [] ? check_for_new_grace_period.clone.21+0x8b/0x97 [ 36.981434] [] ? sched_clock_cpu+0x42/0xc6 [ 36.981440] [] handle_IRQ_event+0x58/0x122 [ 36.981447] [] ? apic_write+0x16/0x18 [ 36.981452] [] handle_edge_irq+0xfa/0x145 [ 36.981458] [] handle_irq+0x88/0x90 [ 36.981463] [] do_IRQ+0x58/0xb0 [ 36.981468] [] ret_from_intr+0x0/0x11 [ 36.981470] [] ? intel_idle+0x115/0x13d [ 36.981480] [] ? intel_idle+0xf4/0x13d [ 36.981485] [] cpuidle_idle_call+0x9e/0x104 [ 36.981489] [] cpu_idle+0xae/0x105 [ 36.981493] [] rest_init+0x72/0x74 [ 36.981498] [] start_kernel+0x3e0/0x3eb [ 36.981503] [] x86_64_start_reservations+0xb6/0xba [ 36.981507] [] x86_64_start_kernel+0x106/0x115 [ 37.200683] ata1: XXX SET EH PENDING, fastdrain=1 [ 37.200692] Pid: 1465, comm: ck-history Not tainted 2.6.37-0.rc4.git1.2.fc15.x86_64 #1 [ 37.200696] Call Trace: [ 37.200699] [] ata_eh_set_pending+0x3e/0x85 [ 37.200715] [] ata_port_schedule_eh+0x43/0x50 [ 37.200720] [] ata_qc_complete+0xd2/0x152 [ 37.200723] [] ata_qc_complete_multiple+0xc6/0xcb [ 37.200727] [] ahci_interrupt+0x4fd/0x5a1 [ 37.200737] [] ? run_timer_softirq+0x28f/0x29e [ 37.200742] [] ? native_sched_clock+0x35/0x37 [ 37.200747] [] ? sched_clock_cpu+0x42/0xc6 [ 37.200752] [] handle_IRQ_event+0x58/0x122 [ 37.200758] [] ? apic_write+0x16/0x18 [ 37.200761] [] handle_edge_irq+0xfa/0x145 [ 37.200766] [] handle_irq+0x88/0x90 [ 37.200769] [] do_IRQ+0x58/0xb0 [ 37.200774] [] ret_from_intr+0x0/0x11 [ 37.200775] [] ? lock_page_cgroup+0x19/0x21 [ 37.200783] [] __mem_cgroup_commit_charge+0x28/0x97 [ 37.200786] [] mem_cgroup_charge_common+0x66/0x76 [ 37.200789] [] mem_cgroup_cache_charge+0xe4/0xf9 [ 37.200794] [] add_to_page_cache_locked+0x42/0x113 [ 37.200797] [] add_to_page_cache_lru+0x2a/0x58 [ 37.200802] [] mpage_readpages+0xa3/0x113 [ 37.200805] [] ? ext4_get_block+0x0/0x18 [ 37.200808] [] ? ext4_get_block+0x0/0x18 [ 37.200811] [] ? zone_statistics+0x65/0x6a [ 37.200816] [] ? alloc_pages_current+0xb2/0xc3 [ 37.200821] [] ext4_readpages+0x1d/0x1f [ 37.200826] [] __do_page_cache_readahead+0x105/0x176 [ 37.200829] [] ra_submit+0x21/0x25 [ 37.200831] [] ondemand_readahead+0x1bc/0x1cb [ 37.200834] [] page_cache_async_readahead+0x7b/0xa3 [ 37.200837] [] generic_file_aio_read+0x2a5/0x5b6 [ 37.200840] [] ? __lru_cache_add+0x34/0x5b [ 37.200844] [] do_sync_read+0xcb/0x108 [ 37.200848] [] ? fsnotify_perm+0x64/0x70 [ 37.200852] [] ? security_file_permission+0x2e/0x33 [ 37.200855] [] vfs_read+0xa9/0xfc [ 37.200857] [] sys_read+0x4a/0x6e [ 37.200860] [] system_call_fastpath+0x16/0x1b [ 37.203575] ata1.00: configured for UDMA/100 [ 37.203582] ata1: EH complete [ 37.239419] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA [ 38.145358] ata1: XXX SET EH PENDING, fastdrain=1 [ 38.145367] Pid: 1489, comm: sata_alpm Not tainted 2.6.37-0.rc4.git1.2.fc15.x86_64 #1 [ 38.145371] Call Trace: [ 38.145384] [] ata_eh_set_pending+0x3e/0x85 [ 38.145391] [] ata_port_schedule_eh+0x43/0x50 [ 38.145400] [] ? _raw_spin_lock_irqsave+0x12/0x2f [ 38.145406] [] ata_scsi_lpm_store+0x89/0xa5 [ 38.145413] [] dev_attr_store+0x20/0x22 [ 38.145422] [] sysfs_write_file+0x114/0x150 [ 38.145430] [] vfs_write+0xac/0xff [ 38.145436] [] sys_write+0x4a/0x6e [ 38.145444] [] system_call_fastpath+0x16/0x1b [ 38.145710] ata2: XXX SET EH PENDING, fastdrain=1 [ 38.145718] Pid: 1489, comm: sata_alpm Not tainted 2.6.37-0.rc4.git1.2.fc15.x86_64 #1 [ 38.145723] Call Trace: [ 38.145730] [] ata_eh_set_pending+0x3e/0x85 [ 38.145737] [] ata_port_schedule_eh+0x43/0x50 [ 38.145743] [] ? _raw_spin_lock_irqsave+0x12/0x2f [ 38.145748] [] ata_scsi_lpm_store+0x89/0xa5 [ 38.145754] [] dev_attr_store+0x20/0x22 [ 38.145760] [] sysfs_write_file+0x114/0x150 [ 38.145767] [] vfs_write+0xac/0xff [ 38.145773] [] sys_write+0x4a/0x6e [ 38.145779] [] system_call_fastpath+0x16/0x1b My whole dmesg from bootup is available at: http://kyle.fedorapeople.org/dmesg There's nothing interesting in my kernel wrt ATA (no patches at all touching it aside from the two from this thread.) Maybe systemd or something during boot-up is poking sysfs, I'll take a look. --Kyle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/