Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758466Ab0LBXn4 (ORCPT ); Thu, 2 Dec 2010 18:43:56 -0500 Received: from adelie.canonical.com ([91.189.90.139]:35774 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758441Ab0LBXny (ORCPT ); Thu, 2 Dec 2010 18:43:54 -0500 Message-ID: <4CF82F2D.8040705@canonical.com> Date: Fri, 03 Dec 2010 07:43:41 +0800 From: Ike Panhc User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Dave Hansen CC: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Matthew Garrett , David Woodhouse Subject: Re: [PATCH 3/3] ideapad: add hotkey support References: <1289977165-14802-1-git-send-email-ike.pan@canonical.com> <1289977238-15113-1-git-send-email-ike.pan@canonical.com> <1291333287.10586.4698.camel@nimitz> In-Reply-To: <1291333287.10586.4698.camel@nimitz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 39 On 12/03/2010 07:41 AM, Dave Hansen wrote: > On Wed, 2010-11-17 at 15:00 +0800, Ike Panhc wrote: >> +static void ideapad_input_report(unsigned long scancode) >> +{ >> + sparse_keymap_report_event(ideapad_priv->inputdev, scancode, 1, true); >> +} > > I got a little build error about some unresolved symbols in the module > while compiling: > > ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined! > ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined! > ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined! > > You can get it to go away by setting CONFIG_INPUT_SPARSEKMAP=m or =y > in .config. But, I think your patches need this: > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index faec777..879d266 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -226,6 +226,7 @@ config IDEAPAD_LAPTOP > tristate "Lenovo IdeaPad Laptop Extras" > depends on ACPI > depends on RFKILL > + select INPUT_SPARSEKMAP > help > This is a driver for the rfkill switches on Lenovo IdeaPad netbooks. > > > Signed-off-by: Dave Hansen > Thanks, you are right -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/