Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756581Ab0LCHJy (ORCPT ); Fri, 3 Dec 2010 02:09:54 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:33612 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755348Ab0LCHJx (ORCPT ); Fri, 3 Dec 2010 02:09:53 -0500 Date: Fri, 3 Dec 2010 02:09:50 -0500 From: Christoph Hellwig To: "Darrick J. Wong" Cc: "Theodore Ts'o" , linux-kernel , linux-ext4 Subject: Re: [PATCH] ext4: Set barrier=0 when block device does not advertise flush support Message-ID: <20101203070950.GA19071@infradead.org> References: <20101203001659.GI18195@tux1.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101203001659.GI18195@tux1.beaverton.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 14 On Thu, Dec 02, 2010 at 04:16:59PM -0800, Darrick J. Wong wrote: > If the user tries to enable write flushes with "barrier=1" and the underlying > block device does not support flushes, print a message and set barrier=0. That doesn't make any sense at all with the ne wFLUSH+FUA code, which is designed to make the cache flushing entirely transparanent. Basically with the new code the barrier option should become a no-op and always enabled. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/