From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lrg@slimlogic.co.uk>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id
Organization: RtpNet
References: <1291368357.20452.6.camel@mola>
Date: Fri, 03 Dec 2010 13:21:22 +0100
In-Reply-To: <1291368357.20452.6.camel@mola> (Axel Lin's message of "Fri, 03
	Dec 2010 17:25:57 +0800")
Message-ID: <874oavqc71.fsf@lechat.rtp-net.org>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 25

Axel Lin <axel.lin@gmail.com> writes:

> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
>
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
>
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.

oh, yeah. makes sense. Thanks for noticing.


Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/