Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932252Ab0LCOQg (ORCPT ); Fri, 3 Dec 2010 09:16:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36555 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117Ab0LCOQf (ORCPT ); Fri, 3 Dec 2010 09:16:35 -0500 Message-ID: <4CF8FBAA.7000807@redhat.com> Date: Fri, 03 Dec 2010 09:16:10 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: vatsa@linux.vnet.ibm.com CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Kiviti , Peter Zijlstra , Ingo Molnar , Anthony Liguori Subject: Re: [RFC PATCH 1/3] kvm: keep track of which task is running a KVM vcpu References: <20101202144129.4357fe00@annuminas.surriel.com> <20101202144324.4a79263b@annuminas.surriel.com> <20101203121746.GE27994@linux.vnet.ibm.com> In-Reply-To: <20101203121746.GE27994@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 18 On 12/03/2010 07:17 AM, Srivatsa Vaddagiri wrote: > On Thu, Dec 02, 2010 at 02:43:24PM -0500, Rik van Riel wrote: >> mutex_lock(&vcpu->mutex); >> + vcpu->task = current; > > Shouldn't we grab reference to current task_struct before storing a pointer to > it? That should not be needed, since current cannot go away without setting vcpu->task back to NULL in vcpu_put. -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/