Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074Ab0LFDwY (ORCPT ); Sun, 5 Dec 2010 22:52:24 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:43366 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185Ab0LFDwX (ORCPT ); Sun, 5 Dec 2010 22:52:23 -0500 Date: Mon, 6 Dec 2010 09:04:55 +0530 From: Balbir Singh To: Minchan Kim Cc: Andrew Morton , Rik van Riel , KOSAKI Motohiro , linux-mm , LKML , KAMEZAWA Hiroyuki Subject: Re: [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list Message-ID: <20101206033455.GA3158@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3981 Lines: 112 * MinChan Kim [2010-12-06 02:29:11]: > Golbal page reclaim moves reclaimalbe pages into inactive list Some typos here and Rik already pointed out some other changes. > to reclaim asap. This patch apply the rule in memcg. > It can help to prevent unnecessary working page eviction of memcg. > > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: Rik van Riel > Cc: KOSAKI Motohiro > Signed-off-by: Minchan Kim > --- > include/linux/memcontrol.h | 6 ++++++ > mm/memcontrol.c | 27 +++++++++++++++++++++++++++ > mm/swap.c | 3 ++- > 3 files changed, 35 insertions(+), 1 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 067115c..8317f5c 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -62,6 +62,7 @@ extern int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, > gfp_t gfp_mask); > extern void mem_cgroup_add_lru_list(struct page *page, enum lru_list lru); > extern void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru); > +extern void mem_cgroup_rotate_reclaimable_page(struct page *page); > extern void mem_cgroup_rotate_lru_list(struct page *page, enum lru_list lru); > extern void mem_cgroup_del_lru(struct page *page); > extern void mem_cgroup_move_lists(struct page *page, > @@ -207,6 +208,11 @@ static inline void mem_cgroup_del_lru_list(struct page *page, int lru) > return ; > } > > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) > +{ > + return ; > +} > + > static inline void mem_cgroup_rotate_lru_list(struct page *page, int lru) > { > return ; > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 729beb7..f9435be 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -829,6 +829,33 @@ void mem_cgroup_del_lru(struct page *page) > mem_cgroup_del_lru_list(page, page_lru(page)); > } > > +/* > + * Writeback is about to end against a page which has been marked for immediate > + * reclaim. If it still appears to be reclaimable, move it to the tail of the > + * inactive list. > + */ > +void mem_cgroup_rotate_reclaimable_page(struct page *page) > +{ > + struct mem_cgroup_per_zone *mz; > + struct page_cgroup *pc; > + enum lru_list lru = page_lru_base_type(page); > + > + if (mem_cgroup_disabled()) > + return; > + > + pc = lookup_page_cgroup(page); > + /* > + * Used bit is set without atomic ops but after smp_wmb(). > + * For making pc->mem_cgroup visible, insert smp_rmb() here. > + */ > + smp_rmb(); > + /* unused or root page is not rotated. */ > + if (!PageCgroupUsed(pc) || mem_cgroup_is_root(pc->mem_cgroup)) > + return; > + mz = page_cgroup_zoneinfo(pc); > + list_move_tail(&pc->lru, &mz->lists[lru]); > +} > + > void mem_cgroup_rotate_lru_list(struct page *page, enum lru_list lru) > { > struct mem_cgroup_per_zone *mz; > diff --git a/mm/swap.c b/mm/swap.c > index 1f36f6f..0fe98e7 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -122,8 +122,9 @@ static void pagevec_move_tail(struct pagevec *pvec) > } > if (PageLRU(page) && !PageActive(page) && > !PageUnevictable(page)) { > - int lru = page_lru_base_type(page); > + enum lru_list lru = page_lru_base_type(page); > list_move_tail(&page->lru, &zone->lru[lru].list); > + mem_cgroup_rotate_reclaimable_page(page); > pgmoved++; > } > } Looks good, do you have any numbers, workloads that benefit? I agree that keeping both global and memcg reclaim in sync is a good idea. Acked-by: Balbir Singh -- Three Cheers, Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/