Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837Ab0LFMe5 (ORCPT ); Mon, 6 Dec 2010 07:34:57 -0500 Received: from mga14.intel.com ([143.182.124.37]:13691 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804Ab0LFMe4 convert rfc822-to-8bit (ORCPT ); Mon, 6 Dec 2010 07:34:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,305,1288594800"; d="scan'208";a="357605119" From: "Dong, Chuanxiao" To: Arnd Bergmann CC: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cjb@laptop.org" , "akpm@linux-foundation.org" , "arjan@linux.intel.com" , "alan@linux.intel.com" , "kmpark@infradead.org" Date: Mon, 6 Dec 2010 20:34:29 +0800 Subject: RE: [PATCH v2 1/4]enable background operations for supported eMMC card Thread-Topic: [PATCH v2 1/4]enable background operations for supported eMMC card Thread-Index: AcuVQTnkpt5GISFGRd+uE2UYdQyiMgAACtlA Message-ID: <5D8008F58939784290FAB48F54975198320B3E49F6@shsmsx502.ccr.corp.intel.com> References: <20101203121338.GB18655@intel.com> <201012061328.49738.arnd@arndb.de> In-Reply-To: <201012061328.49738.arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1867 Lines: 44 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Monday, December 06, 2010 8:29 PM > To: Dong, Chuanxiao > Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; cjb@laptop.org; > akpm@linux-foundation.org; arjan@linux.intel.com; alan@linux.intel.com; > kmpark@infradead.org > Subject: Re: [PATCH v2 1/4]enable background operations for supported eMMC > card > > On Friday 03 December 2010, Chuanxiao Dong wrote: > > From 984adc755cf2f7966a89e510a50f085e314fe347 Mon Sep 17 00:00:00 2001 > > From: Chuanxiao Dong > > Date: Mon, 22 Nov 2010 16:31:12 +0800 > > Subject: [PATCH 1/4] mmc: Enabled background operations feature if eMMC card > supports > > These headers don't belong into a submission. If you use git-send-email, > they get cut off automatically, otherwise just remove them as you paste > the patch into your mail client. > OK. I will remove them when the next submission. > > Background operations is a new feature defined in eMMC4.41 standard. > > Since this feature is opertional for eMMC card, so driver only enable > > s/opertional/optional/ > > @@ -54,6 +54,8 @@ struct mmc_ext_csd { > > unsigned int sec_trim_mult; /* Secure trim multiplier */ > > unsigned int sec_erase_mult; /* Secure erase multiplier */ > > unsigned int trim_timeout; /* In milliseconds */ > > + unsigned int bkops:1; /* background support bit */ > > + unsigned int bkops_en:1; /* background enable bit */ > > }; > > Bit fields are not encouraged for kernel internal data structures, > just use "bool" variables here. Thanks Arnd. I will fix this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/