Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404Ab0LFQDp (ORCPT ); Mon, 6 Dec 2010 11:03:45 -0500 Received: from mga09.intel.com ([134.134.136.24]:33803 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774Ab0LFQDk convert rfc822-to-8bit (ORCPT ); Mon, 6 Dec 2010 11:03:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,305,1288594800"; d="scan'208";a="684369876" From: "Dong, Chuanxiao" To: "linux-mmc@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "cjb@laptop.org" , "arjan@linux.intel.com" , "alan@linux.intel.com" , "akpm@linux-foundation.org" , "Mai, Leonard" , Arnd Bergmann , Wolfram Sang Date: Tue, 7 Dec 2010 00:03:02 +0800 Subject: RE: [PATCH v4 0/4]implement eMMC4.4 standard HW reset feature Thread-Topic: [PATCH v4 0/4]implement eMMC4.4 standard HW reset feature Thread-Index: AcuRVoyV+jZQmGJ7QUmtxU7X3MA6YQEB8Wig Message-ID: <5D8008F58939784290FAB48F54975198320B3E4A2D@shsmsx502.ccr.corp.intel.com> References: <20101201124842.GA5421@intel.com> In-Reply-To: <20101201124842.GA5421@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 49 Hello all, How about these patches? It implemented HW reset feature. When card occurred a timeout error during reading/writing/erasing, these patches will allow driver to reset eMMC card by trigger a HW reset signal. Does anyone have any comments about the implementation of these patches? Wolfram and Arnd already pointed out the unsuitable patch headers. Thanks! :) > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org > [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Chuanxiao Dong > Sent: Wednesday, December 01, 2010 8:49 PM > To: linux-mmc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; cjb@laptop.org; arjan@linux.intel.com; > alan@linux.intel.com; akpm@linux-foundation.org > Subject: [PATCH v4 0/4]implement eMMC4.4 standard HW reset feature > > Hi, > These are the version 4 patches to implement eMMC4.4 HW reset > feature. Host controller can use this feature by trigger RST_n signal. > To enable this, byte 162 of EXT_CSD register should be set. > HW reset is implemented in mmc core layer and sdhci host layer, and it > will be used after each reading/writing/erasing timeout error occures. > > change-log: > This version change the way to detect timeout error conditions. Added a > new routine mmc_handle_timeout_error to do this instead to do this in > mmc_wait_for_req. Each timeout read/write/erase command can use this > routine to do HW reset. > > patch1: enable HW reset capability if card support. > > patch2: add two new callback to implement HW reset in mmc core layer. In > this patch, routine mmc_handle_timeout_error was added. > > patch3: implement hardware_reset callback for sdhci host. A new callback > reset_emmc was defined which will be each sdhci host controller to > implement separately. > > patch4: did a HW reset after each read/write/erase command. > > Thanks > Chuanxiao > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/