Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884Ab0LFSLM (ORCPT ); Mon, 6 Dec 2010 13:11:12 -0500 Received: from mail-gw0-f42.google.com ([74.125.83.42]:60661 "EHLO mail-gw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778Ab0LFSLK (ORCPT ); Mon, 6 Dec 2010 13:11:10 -0500 Date: Mon, 6 Dec 2010 16:11:27 -0200 From: "Gustavo F. Padovan" To: Joe Perches Cc: Marcel Holtmann , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address Message-ID: <20101206181127.GB883@vigoh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 37 Hi Joe, * Joe Perches [2010-12-03 18:33:03 -0800]: > Bluetooth output the MAC address in reverse order. > Bluetooth memory order: 00 01 02 03 04 05 is output "05:04:03:02:01:00". > > This can save overall text when bluetooth is compiled in. > > Bluetooth currently uses a very slightly unsafe local function (batostr) > to output these formatted addresses. > > Adding %pMbt allows the batostr function to be removed. > > For x86: > > $ size lib/vsprintf*.o* > text data bss dec hex filename > 8189 0 2 8191 1fff lib/vsprintf.o.defconfig.new > 8150 0 2 8152 1fd8 lib/vsprintf.o.defconfig.old > 18633 56 3936 22625 5861 lib/vsprintf.o.allyesconfig.new > 18571 56 3920 22547 5813 lib/vsprintf.o.allyesconfig.old > > Signed-off-by: Joe Perches Looks good to me. Acked-by: Gustavo F. Padovan -- Gustavo F. Padovan http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/