DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=XZzS8/x7Ts+TWGcmKKqFHfnUssIbM0v2WaQszi3PS6aHiqDQRUKGJtr4DTv64qUJ2W
         c2E5aiVtDCf3MsXequyOTHs9Zi5aHEZphuaTJHfWVhnhkjWSHINnOTyWGQA6IO/6+hMb
         9nD+BXcT1P1sO5+k9zS1HnXpmighhHYPGKg6o=
Date: Mon, 6 Dec 2010 22:10:08 +0200
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Tilman Schmidt <t.schmidt@phoenixsoftware.de>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 26/45] kstrtox: convert drivers/isdn/
Message-ID: <20101206201008.GA5650@core2.telecom.by>
References: <1291571382-2719-1-git-send-email-adobriyan@gmail.com>
 <1291571382-2719-26-git-send-email-adobriyan@gmail.com>
 <4CFC2A05.7010509@phoenixsoftware.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CFC2A05.7010509@phoenixsoftware.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1674
Lines: 46

On Mon, Dec 06, 2010 at 01:10:45AM +0100, Tilman Schmidt wrote:
> I like the patch, but why not go all the way?
> 
> Am 05.12.2010 18:49 schrieb Alexey Dobriyan:
> > @@ -566,10 +566,10 @@ void gigaset_handle_modem_response(struct cardstate *cs)
> >  		case RT_ZCAU:
> >  			event->parameter = -1;
> >  			if (curarg + 1 < params) {
> > -				unsigned long type, value;
> > +				u8 type, value;
> >  
> > -				i = strict_strtoul(argv[curarg++], 16, &type);
> > -				j = strict_strtoul(argv[curarg++], 16, &value);
> > +				i = kstrtou8(argv[curarg++], 16, &type);
> > +				j = kstrtou8(argv[curarg++], 16, &value);
> >  
> >  				if (i == 0 && type < 256 &&
> >  				    j == 0 && value < 256)
> 
> Once type and value are u8, the checks for < 256 are unnecessary.

OK.

> > @@ -583,7 +583,7 @@ void gigaset_handle_modem_response(struct cardstate *cs)
> >  				unsigned long res;
> >  				int rc;
> >  
> > -				rc = strict_strtoul(argv[curarg++], 10, &res);
> > +				rc = kstrtoul(argv[curarg++], 10, &res);
> >  				if (rc == 0)
> >  					event->parameter = res;
> >  			}
> 
> The new kstrtoul() promises not to touch the result field in the event
> of a conversion error, so &event->parameter can be passed directly to
> it, getting rid of the variables rc and res and the if statement.

What should be done in case of error?
Compiler will warn if kstrto*() result is unused:

	kstrtoul(argv[curarg++], 10, &event->parameter);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/