Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754065Ab0LFVdV (ORCPT ); Mon, 6 Dec 2010 16:33:21 -0500 Received: from serv04.lahn.de ([213.239.197.57]:42525 "EHLO serv04.lahn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794Ab0LFVdT (ORCPT ); Mon, 6 Dec 2010 16:33:19 -0500 Date: Mon, 6 Dec 2010 22:27:03 +0100 From: Michael Leun To: Jesse Gross Cc: Eric Dumazet , David Miller , Ben Greear , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used Message-ID: <20101206222703.32fbe852@xenia.leun.net> In-Reply-To: References: <20101129201716.1d0257c4@xenia.leun.net> <4CF442FA.4070701@candelatech.com> <20101130095944.41b5f7b6@xenia.leun.net> <1291108809.2904.3.camel@edumazet-laptop> <20101201111716.424fb771@xenia.leun.net> <1291200914.2856.546.camel@edumazet-laptop> <20101205030712.36149bc2@xenia.leun.net> <1291536233.2806.102.camel@edumazet-laptop> <20101205105528.49fa9a9f@xenia.leun.net> <20101205114404.7c0cddc2@xenia.leun.net> <20101206203437.54b550e0@xenia.leun.net> Organization: Not Organized X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3696 Lines: 96 On Mon, 6 Dec 2010 12:04:48 -0800 Jesse Gross wrote: > On Mon, Dec 6, 2010 at 11:34 AM, Michael Leun > wrote: > > On Mon, 6 Dec 2010 10:14:55 -0800 > > Jesse Gross wrote: > > > >> On Sun, Dec 5, 2010 at 2:44 AM, Michael Leun > >> wrote: > >> > Hi Jesse, > >> > > >> > On Sun, 5 Dec 2010 10:55:28 +0100 > >> > Michael Leun wrote: > >> > > >> >> On Sun, 05 Dec 2010 09:03:53 +0100 > >> >> Eric Dumazet wrote: > >> >> > >> >> > > But on > >> >> > > > >> >> > > hpdl320g5:/home/ml # lspci | grep Eth > >> >> > > 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme > >> >> > > BCM5714 Gigabit Ethernet (rev a3) 03:04.1 Ethernet > >> >> > > controller: Broadcom Corporation NetXtreme BCM5714 Gigabit > >> >> > > Ethernet (rev a3) > >> >> > > > >> >> > > the good message is that it also does not crash, but with > >> >> > > tcpdump I see vlan tags when no vlan devices configured on > >> >> > > the respective eth, if so I do not see tags anymore vlan > >> >> > > tags on the trunk interface. > >> >> > > > >> >> > > >> >> > For all these very specific needs, you'll have to try 2.6.37 > >> >> > I am afraid. Jesse did huge changes to exactly make this > >> >> > working, we wont backport this to 2.6.36, but only avoid > >> >> > crashes. > >> >> > >> >> OK, I'm perfectly fine with that, of course, actually nice to > >> >> hear that the issue already is addressed. > >> >> > >> >> Likely I'll give some rc an shot on this machine (maybe over > >> >> christmas), but it is an production machine (acutally testing > >> >> other devices is the "product" produced on this machine), so > >> >> unfortunately I'm not that free in when and what I can do (but > >> >> the possibility to, for example, bridge the trunk interface > >> >> would make testing easier, that justifies something...). > >> >> > >> >> Thank you all very much for your work. > >> > > >> > Are these changes already in 2.6.37-rc4? Or, if not are they > >> > somewhere publically available already? > >> > > >> > I looked into various changelogs but have some difficulties to > >> > identify them... > >> > > >> > Maybe I have some time next days to give them an try... > >> > >> Yes, all of the existing vlan changes are in 2.6.37-rc4. ?There > >> were a number of patches but the main one was > >> 3701e51382a026cba10c60b03efabe534fba4ca4 > > > > Then, I'm afraid, this (seeing vlan tags even if vlan interfaces are > > configured) does not work on HP DL320G5 (for exact description and > > examples please see my mail a few days ago). > > What driver are you using? Is it tg3? > > The vlan changes that I made unfortunately require updating drivers to > get the full benefit. I've been busy lately so tg3 hasn't yet been > updated. > > I know that tg3 does some things differently depending on whether a > vlan group is configured, so that would likely be the cause of what > you are seeing. I'd have to look at it in more detail to be sure > though. > > You said that everything works on the other Broadcom NIC that you > tested? Maybe it uses bnx2 instead? > Both machines use tg3 / 2.6.36.1 - one is opensuse, one ubuntu (but this should not matter, I think). If I can do anything to support your investigations / work (most likely testing / providing information) please let me know. -- MfG, Michael Leun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/