Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258Ab0LGARW (ORCPT ); Mon, 6 Dec 2010 19:17:22 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:42074 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073Ab0LGARV convert rfc822-to-8bit (ORCPT ); Mon, 6 Dec 2010 19:17:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YvTe2K1vTRuCaILjKF30zW+O4L6zLguimpuhfH2KDlgI1d812X8bBUjnriy5jO4w0P owMfUmLqRQnmqVhSWHP/0aepesO1D3OCOAEfZ9cnkw0CzmbTKmbxyIkG+nAnwMVloFeh H3EBy7fC4PMCOt4Pa5uKb8XBOIbQrwZr0+Ia0= MIME-Version: 1.0 In-Reply-To: <4CFC52D7.8040003@redhat.com> References: <4CFC52D7.8040003@redhat.com> Date: Tue, 7 Dec 2010 09:17:21 +0900 Message-ID: Subject: Re: [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list From: Minchan Kim To: Rik van Riel Cc: Andrew Morton , KOSAKI Motohiro , linux-mm , LKML , Balbir Singh , KAMEZAWA Hiroyuki Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 42 On Mon, Dec 6, 2010 at 12:04 PM, Rik van Riel wrote: > On 12/05/2010 12:29 PM, Minchan Kim wrote: >> >> Golbal page reclaim moves reclaimalbe pages into inactive list >> to reclaim asap. This patch apply the rule in memcg. >> It can help to prevent unnecessary working page eviction of memcg. > > The patch is right, but the description is wrong. > > The rotate_reclaimable_page function moves just written out > pages, which the VM wanted to reclaim, to the end of the > inactive list. ?That way the VM will find those pages first > next time it needs to free memory. Will fix. > >> Cc: Balbir Singh >> Cc: KAMEZAWA Hiroyuki >> Cc: Rik van Riel >> Cc: KOSAKI Motohiro >> Signed-off-by: Minchan Kim > > Reviewed-by: Rik van Riel Thanks, Rik. > > -- > All rights reversed > -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/