Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751142Ab0LGFGX (ORCPT ); Tue, 7 Dec 2010 00:06:23 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42500 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746Ab0LGFGV (ORCPT ); Tue, 7 Dec 2010 00:06:21 -0500 Content-Type: text/plain; charset=UTF-8 Cc: Avantika Mathur , Jason Baron , Randy Dunlap , Steven Rostedt , Frederic Weisbecker , Ingo Molnar , Heiko Carstens , linux-doc , linux-kernel Subject: Re: [PATCH 4/6] ftrace syscalls: Allow arch specific syscall symbol matching From: Ian Munsie To: Mike Frysinger In-reply-to: References: <1291696151-4336-1-git-send-email-imunsie@au1.ibm.com> <1291696151-4336-5-git-send-email-imunsie@au1.ibm.com> Date: Tue, 07 Dec 2010 16:06:18 +1100 Message-Id: <1291698267-sup-2037@au1.ibm.com> User-Agent: Sup/0.11 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 18 Excerpts from Mike Frysinger's message of Tue Dec 07 15:56:49 +1100 2010: > useless set of parenthesis, and this overhead sucks. weak + > additional function call just for a strcmp for most people ? why not > make it into a define in the header: > #ifndef arch_syscall_match_sym_name > #define arch_syscall_match_sym_name(sym, name) !strcmp(sym + 3, name + 3) > #endif > -mike No problem, will change it. Cheers, -Ian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/