Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197Ab0LGOh4 (ORCPT ); Tue, 7 Dec 2010 09:37:56 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:52436 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753962Ab0LGOhz (ORCPT ); Tue, 7 Dec 2010 09:37:55 -0500 Date: Tue, 7 Dec 2010 15:37:38 +0100 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , Rik van Riel , KOSAKI Motohiro , linux-mm , LKML Subject: Re: [PATCH v4 1/7] Fix checkpatch's report in swap.c Message-ID: <20101207143738.GA2356@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 42 On Mon, Dec 06, 2010 at 02:29:09AM +0900, Minchan Kim wrote: > checkpatch reports following problems. > It's a very annoying. This patch fixes it. > > barrios@barrios-desktop:~/linux-2.6$ ./scripts/checkpatch.pl -f mm/swap.c > WARNING: line over 80 characters > + if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) { > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > +EXPORT_SYMBOL(mark_page_accessed); > > ERROR: code indent should use tabs where possible > + ^I^I}$ > > WARNING: please, no space before tabs > + ^I^I}$ > > WARNING: please, no spaces at the start of a line > + ^I^I}$ > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > +EXPORT_SYMBOL(__pagevec_release); > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > +EXPORT_SYMBOL(____pagevec_lru_add); > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > +EXPORT_SYMBOL(pagevec_lookup); > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > +EXPORT_SYMBOL(pagevec_lookup_tag); > > total: 1 errors, 8 warnings, 517 lines checked > > Signed-off-by: Minchan Kim Reviewed-by: Johannes Weiner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/