Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544Ab0LGPFo (ORCPT ); Tue, 7 Dec 2010 10:05:44 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:57895 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454Ab0LGPFn (ORCPT ); Tue, 7 Dec 2010 10:05:43 -0500 Date: Tue, 7 Dec 2010 16:05:25 +0100 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , Rik van Riel , KOSAKI Motohiro , linux-mm , LKML , Wu Fengguang , Nick Piggin Subject: Re: [PATCH v4 4/7] Reclaim invalidated page ASAP Message-ID: <20101207150525.GD2356@cmpxchg.org> References: <0724024711222476a0c8deadb5b366265b8e5824.1291568905.git.minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0724024711222476a0c8deadb5b366265b8e5824.1291568905.git.minchan.kim@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2484 Lines: 72 On Mon, Dec 06, 2010 at 02:29:12AM +0900, Minchan Kim wrote: > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -275,26 +275,59 @@ void add_page_to_unevictable_list(struct page *page) > * head of the list, rather than the tail, to give the flusher > * threads some time to write it out, as this is much more > * effective than the single-page writeout from reclaim. > + * > + * If the page isn't page_mapped and dirty/writeback, the page > + * could reclaim asap using PG_reclaim. > + * > + * 1. active, mapped page -> none > + * 2. active, dirty/writeback page -> inactive, head, PG_reclaim > + * 3. inactive, mapped page -> none > + * 4. inactive, dirty/writeback page -> inactive, head, PG_reclaim inactive, clean -> inactive, tail > + * 5. Others -> none > + * > + * In 4, why it moves inactive's head, the VM expects the page would > + * be write it out by flusher threads as this is much more effective > + * than the single-page writeout from reclaim. > */ > static void lru_deactivate(struct page *page, struct zone *zone) > { > int lru, file; > + bool active; > > - if (!PageLRU(page) || !PageActive(page)) > + if (!PageLRU(page)) > return; > > /* Some processes are using the page */ > if (page_mapped(page)) > return; > > + active = PageActive(page); > + > file = page_is_file_cache(page); > lru = page_lru_base_type(page); > - del_page_from_lru_list(zone, page, lru + LRU_ACTIVE); > + del_page_from_lru_list(zone, page, lru + active); > ClearPageActive(page); > ClearPageReferenced(page); > add_page_to_lru_list(zone, page, lru); > - __count_vm_event(PGDEACTIVATE); > > + if (PageWriteback(page) || PageDirty(page)) { > + /* > + * PG_reclaim could be raced with end_page_writeback > + * It can make readahead confusing. But race window > + * is _really_ small and it's non-critical problem. > + */ > + SetPageReclaim(page); > + } else { > + /* > + * The page's writeback ends up during pagevec > + * We moves tha page into tail of inactive. > + */ > + list_move_tail(&page->lru, &zone->lru[lru].list); > + mem_cgroup_rotate_reclaimable_page(page); I think you also need to increase PGROTATED here. Other than that, Reviewed-by: Johannes Weiner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/