Date: Tue, 07 Dec 2010 17:14:33 +0100
Message-ID: <s5hwrnlftli.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Chris Ball <cjb@laptop.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Aries Lee <arieslee@jmicron.com>
Subject: Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller
In-Reply-To: <20101124220425.GA18464@pengutronix.de>
References: <1290579674-4616-1-git-send-email-tiwai@suse.de>
	<1290579674-4616-2-git-send-email-tiwai@suse.de>
	<20101124095935.GA6812@pengutronix.de>
	<s5hy68jq7re.wl%tiwai@suse.de>
	<20101124220425.GA18464@pengutronix.de>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 31

At Wed, 24 Nov 2010 23:04:25 +0100,
Wolfram Sang wrote:
> 
> On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote:
> > At Wed, 24 Nov 2010 10:59:35 +0100,
> > Wolfram Sang wrote:
> > > 
> > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote:
> > > 
> > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */
> > > > +#define SDHCI_QUIRK_MMC_VDD_180				(1<<30)
> > > 
> > > Can't we handle this more generic? Like setting ocr_avail_* from
> > > sdhci-pci.c somehow (just brainstorming, didn't have a deeper look)? I'd
> > > like to avoid new quirks as much as possible.
> > 
> > OK, what about the one below?
> 
> Looks better to me. (sadly, still from a glimpse, no thorough review)

Chris, any chance to take a look at this?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/