Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754267Ab0LGTPO (ORCPT ); Tue, 7 Dec 2010 14:15:14 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:51660 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753499Ab0LGTPK (ORCPT ); Tue, 7 Dec 2010 14:15:10 -0500 Date: Tue, 7 Dec 2010 14:05:28 -0500 From: "John W. Linville" To: Joe Perches Cc: "Luis R. Rodriguez" , linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net, ath9k-devel@venema.h4ckr.net, Peter Stuge , Felix Fietkau , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 0/4] ath: logging message conversion Message-ID: <20101207190528.GD2700@tuxdriver.com> References: <20101202190239.GE7399@tux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 30 On Thu, Dec 02, 2010 at 07:12:34PM -0800, Joe Perches wrote: > ath_print is misleading as it's only used with CONFIG_ATH_DEBUG. > > Add and use the more normal _printk and _ > printk equivalents. (ath_printk and ath_) > > Fix various defects in the current uses of ath_print formats > and arguments: Unnecessary casts, missing newlines, multiple > prints, and 1 loop which can exceed array bounds. > > Bundled and integrated the individual patches into a single patch series. > > Joe Perches (4): > ath: Add and use ath_printk and ath_ > ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err > ath: Convert ath_print to ath_dbg > ath: Fix ath_dbg access beyond array bound Is the Atheros crew happy with this series? They didn't seem to like the original patches very much... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/