Message-ID: <4CFE9FF6.2080800@euromail.se>
Date: Tue, 07 Dec 2010 21:58:30 +0100
From: Henrik Rydberg <rydberg@euromail.se>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6
MIME-Version: 1.0
To: Ping Cheng <pinglinux@gmail.com>
CC: Jiri Kosina <jkosina@suse.cz>, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Ping Cheng <pingc@wacom.com>, Chris Bagwell <chris@cnpbagwell.com>,
        Peter Hutterer <peter.hutterer@who-t.net>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] input: mt: Move tracking and pointer emulation to
 input-mt
References: <1291722357-22820-1-git-send-email-rydberg@euromail.se>	<alpine.LNX.2.00.1012071553100.14806@pobox.suse.cz>	<4CFE934D.4040309@euromail.se> <AANLkTik=A5xc2RexWqDMvumFqbA6HtzynWmP=Fz6+SvE@mail.gmail.com>
In-Reply-To: <AANLkTik=A5xc2RexWqDMvumFqbA6HtzynWmP=Fz6+SvE@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 787
Lines: 27

>

> Acked-by: Ping Cheng <pingc@wacom.com>


Thanks.


> I do see an issue when pen coming in prox while fingers were on the
> tablet. Fingers up events are missing.

>
> Since it is unrelated to this patch, I'll submit another patch as a
> bug fix later.

Actually, I believe it is correct as is. One could always argue (and I did at
the time of that change) whether touch up is the right thing to do in the
proximity of the pen, but that is what the code does now. As proof, check how
input_mt_report_slot_state() is used.

Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/