Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228Ab0LHCIa (ORCPT ); Tue, 7 Dec 2010 21:08:30 -0500 Received: from ozlabs.org ([203.10.76.45]:54359 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756199Ab0LHCI0 (ORCPT ); Tue, 7 Dec 2010 21:08:26 -0500 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Subject: [PATCH 0/2] Common struct clk implementation, v8 Message-Id: <1291774094.269634.503532219345.0.gpush@pororo> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org From: Jeremy Kerr Date: Wed, 08 Dec 2010 10:08:14 +0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3252 Lines: 95 [apologies for the resend: missed this series description] Hi all, These patches are an attempt to allow platforms to share clock code. At present, the definitions of 'struct clk' are local to platform code, which makes allocating and initialising cross-platform clock sources difficult, and makes it impossible to compile a single image containing support for two ARM platforms with different struct clks. The two patches are for the architecture-independent kernel code, introducing the common clk infrastructure. The changelog for the first patch includes details about the new clock definitions. As requested by rmk, I've put together a small series of patches illustrating the usage of the common struct clock on the ARM imx51 platform. These are available in my git tree: git://kernel.ubuntu.com/jk/dt/linux-2.6 in the clk-common-mx51 branch (clk-common..clk-common-mx51). There is also a port for versatile (clk-common-versatile) in this tree too. The approach I've taken with the imx51 port is to temporarly duplicate the platform-common clock code (ie, for all mxc-based boards) to enable usage of the common struct clk on one machine (imx51), while leaving the others as-is. For a proper platform-wide usage of the common struct clk, we'd be better off doing the whole platform at once. However, mx51 is the only mxc-based HW I have, hence the duplicated example port. In the example port, the first change simply converts the mxc's struct clk to a struct clk_mxc, using the new API. The subsequent patches move certain clocks to more specific data structures (eg clk_fixed and clk_pll) where possible. Ben Herrenschmidt is looking at using common struct clk code for powerpc too, hence the kernel-wide approach. Many thanks to the following for their input: * Ben Dooks * Baruch Siach * Russell King * Uwe Kleine-König * Lorenzo Pieralisi * Vincent Guittot Russell - now that we've had a few platforms ported to the common clk infrastructure, I believe it's ready to merge. If so, do you want this in the patch tracker? Otherwise, let me know what needs changing. Cheers, Jeremy -- v8: * add atomic clocks, and locking wrappers * expand comments on clk and clk_ops v7: * change CLK_INIT to initialise clk->mutex statically v6: * fixed up references to 'clk_operations' in the changelog v5: * uninline main API, and share definitions with !USE_COMMON_STRUCT_CLK * add __clk_get * delay mutex init * kerneldoc for struct clk v4: * use mutex for enable/disable locking * DEFINE_CLK -> INIT_CLK, and pass the clk name for mutex init * struct clk_operations -> struct clk_ops v3: * do clock usage refcounting in common code * provide sample port v2: * no longer ARM-specific * use clk_operations --- Jeremy Kerr (2): Add a common struct clk clk: Generic support for fixed-rate clocks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/