Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482Ab0LHI5L (ORCPT ); Wed, 8 Dec 2010 03:57:11 -0500 Received: from mail-fx0-f43.google.com ([209.85.161.43]:37184 "EHLO mail-fx0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666Ab0LHI5J convert rfc822-to-8bit (ORCPT ); Wed, 8 Dec 2010 03:57:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=aTLokGDA92B/GMjUtK/4fDjx1SVwN9ADWIu8dwTRKtu4b0mQt33frW8AuNNBgmFsE2 GRa8mjdU+y+fWCDdt/xuNQs8XcIjCvWjhObd38DGhVlcsDG7YZhCBaYKMX2OqBuamMqj h1GqRDor+Tk5ag/VLShqVSNgWaH1O35CrmHPg= MIME-Version: 1.0 In-Reply-To: <4CFEB6EB.9070502@redhat.com> References: <4CFEB6EB.9070502@redhat.com> Date: Wed, 8 Dec 2010 09:57:07 +0100 X-Google-Sender-Auth: 94AG5F3QBGhjUpSuF8tXsT0RgQo Message-ID: Subject: Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5) From: Geert Uytterhoeven To: Mauro Carvalho Chehab Cc: Arnaud Lacombe , Michal Marek , Linus Torvalds , brueckner@linux.vnet.ibm.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3633 Lines: 82 On Tue, Dec 7, 2010 at 23:36, Mauro Carvalho Chehab wrote: > Em 07-12-2010 18:45, Geert Uytterhoeven escreveu: >> On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe wrote: >>> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven wrote: >>>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe wrote: >>>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven wrote: >>>>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek wrote: >>>>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest >>>>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud >>>>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if' >>>>>>> keyword to the Kconfig language, so it's not exactly something that one >>>>>>> would expect in the rc phase, but the kconfig change is not huge (the >>>>>>> large diff is due to generated files) and it is deployed only in those >>>>>>> five Kconfig files that had the warnings and were hard to fix by other >>>>>>> means.  The second part is a forgotten patch by Hendrik Brueckner to >>>>>>> usr/initramfs, that fixes build for Blackfin and h8300. >>>>>> >>>>>>> Arnaud Lacombe (5): >>>>>>>      kconfig: add an option to determine a menu's visibility >>>>>> >>>>>> Hmm, this changeset also went in through the v4l tree? >>>>>> >>>>> Mauro merely imported the set in his tree to give them visibility and >>>>> testing, but they went in trough the kbuild tree after being in -next >>>>> for a week. >>>> >>>> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't >>>> show a SoB from Michal... >>>> >>> Why would you expect it to ? Most of the commit in Linus' tree are not >>> personally SoB by him. >> >> Sorry, you're right. >> >>>>>> BTW, I got confused: >>>>>>  - make allmodconfig causes e.g.: >>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y >>>>>>        CONFIG_VIDEO_TVAUDIO=m >>>>>>    => good >>>>>>  - make oldconfig for my config with almost everything selected, >>>>>> except for stuff I know that breaks: >>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y >>>>>>        # CONFIG_VIDEO_TVAUDIO is not set >>>>>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y? >>>>>>    => bad! >>>>> that's difficult to judge without your old configuration. >>>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give >>>>> information about. >>>> >>>> I don't have PCI, so I cannot enable VIDEO_BT848. >>>> >>> so why do you expect VIDEO_TVAUDIO to be enabled ? >> >> I don't expect it to be enabled, I expected to be able to enable it. >> Allmodconfig >> does enable it. > > Why do you want to enable a device that doesn't work? There's no other driver > but bttv that has upport for the devices implemented by tvaudio module. > > /me is confused... Compile coverage? Haven't checked yet whether it gets enabled with allyesconfig, but allyesconfig contains a few things that don't work. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/