Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507Ab0LHJNF (ORCPT ); Wed, 8 Dec 2010 04:13:05 -0500 Received: from mail-ey0-f171.google.com ([209.85.215.171]:55498 "EHLO mail-ey0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842Ab0LHJNA convert rfc822-to-8bit (ORCPT ); Wed, 8 Dec 2010 04:13:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=uP3PC+CvCAp9AHCTPYfQbQ12czZ/mmxeHYfOQWwkSTkBggmVL5iZc6SphAkoIm3B3O 1UMt6PSq6Hd3UzXgmdAS0TX6Ep1LcpHXUoyxora87OE4ayFndZtq5T2b5Xxa5wBN5tQV Ih2Gi3IJRbeW6LPT9DSqbG5HB5JxXMKBrRaYM= MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 8 Dec 2010 10:12:58 +0100 Message-ID: Subject: Re: linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!) From: Corentin Chary To: sedat.dilek@gmail.com, Matthew Garrett Cc: LKML , platform-driver-x86@vger.kernel.org, Stephen Rothwell , Randy Dunlap Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6945 Lines: 153 On Wed, Dec 8, 2010 at 9:17 AM, Sedat Dilek wrote: > Hi, > > just wanted to build a new linux-next and see this: > > [ setup.log ] > ... > dileks.1" make -C 'debian/build/source_i386_none' > O='/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686' > oldnoconfig > make[2]: Entering directory > `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >  HOSTCC  scripts/basic/fixdep >  HOSTCC  scripts/basic/docproc >  GEN     /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile >  HOSTCC  scripts/kconfig/conf.o >  HOSTCC  scripts/kconfig/kxgettext.o >  SHIPPED scripts/kconfig/zconf.tab.c >  SHIPPED scripts/kconfig/lex.zconf.c >  SHIPPED scripts/kconfig/zconf.hash.c >  HOSTCC  scripts/kconfig/zconf.tab.o >  HOSTLD  scripts/kconfig/conf > scripts/kconfig/conf --oldnoconfig Kconfig > drivers/platform/x86/Kconfig:422:error: recursive dependency detected! > drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI > drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI > drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS > drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI > warning: (ADB_PMU_LED && MACINTOSH_DRIVERS && ADB_PMU || ATH5K && > NETDEVICES && WLAN && ATH_COMMON && (PCI || ATHEROS_AR231X) && > MAC80211 || ATH9K && NETDEVICES && WLAN && ATH_COMMON && PCI && > MAC80211 || ATH9K_HTC && NETDEVICES && WLAN && ATH_COMMON && USB && > MAC80211 || CARL9170_LEDS && NETDEVICES && WLAN && ATH_COMMON && > CARL9170 || INPUT_WISTRON_BTNS && !S390 && INPUT && INPUT_MISC && X86 > && !X86_64 || SENSORS_APPLESMC && HWMON && INPUT && X86 || > SENSORS_LIS3LV02D && HWMON && ACPI && INPUT || IR_WINBOND_CIR && > MEDIA_SUPPORT && X86 && PNP && RC_CORE || BACKLIGHT_ADP8860 && > HAS_IOMEM && BACKLIGHT_LCD_SUPPORT && BACKLIGHT_CLASS_DEVICE && I2C || > MSM_STAGING && STAGING && !STAGING_EXCLUDE_BUILD && FB && ARCH_MSM && > !FB_MSM || ASUS_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && > !ACPI_ASUS && INPUT && (RFKILL || RFKILL=n) || THINKPAD_ACPI && X86 && > X86_PLATFORM_DEVICES && ACPI && INPUT && (RFKILL || RFKILL=n) || > EEEPC_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && > EXPERIMENTAL && (RFKILL || RFKILL=n) && HOTPLUG_PCI || EEEPC_WMI && > X86 && X86_PLATFORM_DEVICES && ACPI_WMI && INPUT && EXPERIMENTAL && > BACKLIGHT_CLASS_DEVICE && (RFKILL || RFKILL=n)) selects LEDS_CLASS > which has unmet direct dependencies (NEW_LEDS) > # > # configuration written to .config > # > make[2]: Leaving directory > `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' > env -u ABINAME -u ARCH -u FEATURESET -u FLAVOUR -u VERSION -u > LOCALVERSION DISTRIBUTION_OFFICIAL_BUILD=1 > DISTRIBUTION_UPLOADER=sedat.dilek@gmail.com > DISTRIBUTION_VERSION="2.6.37~rc5-1~next20101208.dileks.1" make -C > 'debian/build/source_i386_none' > O='/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686' >  prepare > make[2]: Entering directory > `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >  GEN     /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile > scripts/kconfig/conf --silentoldconfig Kconfig > drivers/platform/x86/Kconfig:422:error: recursive dependency detected! > drivers/platform/x86/Kconfig:422:       symbol EEEPC_WMI depends on ACPI_WMI > drivers/platform/x86/Kconfig:438:       symbol ACPI_WMI is selected by ACER_WMI > drivers/platform/x86/Kconfig:18:        symbol ACER_WMI depends on LEDS_CLASS > drivers/leds/Kconfig:10:        symbol LEDS_CLASS is selected by EEEPC_WMI > warning: (ADB_PMU_LED && MACINTOSH_DRIVERS && ADB_PMU || ATH5K && > NETDEVICES && WLAN && ATH_COMMON && (PCI || ATHEROS_AR231X) && > MAC80211 || ATH9K && NETDEVICES && WLAN && ATH_COMMON && PCI && > MAC80211 || ATH9K_HTC && NETDEVICES && WLAN && ATH_COMMON && USB && > MAC80211 || CARL9170_LEDS && NETDEVICES && WLAN && ATH_COMMON && > CARL9170 || INPUT_WISTRON_BTNS && !S390 && INPUT && INPUT_MISC && X86 > && !X86_64 || SENSORS_APPLESMC && HWMON && INPUT && X86 || > SENSORS_LIS3LV02D && HWMON && ACPI && INPUT || IR_WINBOND_CIR && > MEDIA_SUPPORT && X86 && PNP && RC_CORE || BACKLIGHT_ADP8860 && > HAS_IOMEM && BACKLIGHT_LCD_SUPPORT && BACKLIGHT_CLASS_DEVICE && I2C || > MSM_STAGING && STAGING && !STAGING_EXCLUDE_BUILD && FB && ARCH_MSM && > !FB_MSM || ASUS_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && > !ACPI_ASUS && INPUT && (RFKILL || RFKILL=n) || THINKPAD_ACPI && X86 && > X86_PLATFORM_DEVICES && ACPI && INPUT && (RFKILL || RFKILL=n) || > EEEPC_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && > EXPERIMENTAL && (RFKILL || RFKILL=n) && HOTPLUG_PCI || EEEPC_WMI && > X86 && X86_PLATFORM_DEVICES && ACPI_WMI && INPUT && EXPERIMENTAL && > BACKLIGHT_CLASS_DEVICE && (RFKILL || RFKILL=n)) selects LEDS_CLASS > which has unmet direct dependencies (NEW_LEDS) >  Using /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none > as source for kernel >  GEN     /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile >  CHK     include/linux/version.h >  UPD     include/linux/version.h >  CHK     include/generated/utsrelease.h >  UPD     include/generated/utsrelease.h >  CC      kernel/bounds.s >  GEN     include/generated/bounds.h >  CC      arch/x86/kernel/asm-offsets.s >  GEN     include/generated/asm-offsets.h >  CALL    /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none/scripts/checksyscalls.sh > make[2]: Leaving directory > `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' > make[1]: Leaving directory `/home/sd/src/linux-2.6/linux-2.6.37-rc5' > > Regards, > - Sedat - > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Hum ... ACER_WMI: select ACPI_WMI depends on LEDS_CLASS depends on NEW_LEDS EEEPC_WMI: depends on ACPI_WMI select LEDS_CLASS select NEW_LEDS I don't really see how it's a recursive dependency, but maybe it's time to clean this KConfig. What is our current policy about that ? I think we should *depends* on important subsystem (ACPI, INPUT, ...) and select obscure things so that the driver does not get lost if you don't enable the leds. depends: - ACPI - INPUT - EXPERIMENTAL - RFKILL - ACPI_WMI ? - HWMON ? - THERMAL ? select: - BACKLIGHT_CLASS_* - LEDS_CLASS - NEW_LEDS - INPUT_* -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/