Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755116Ab0LHNyB (ORCPT ); Wed, 8 Dec 2010 08:54:01 -0500 Received: from g4t0017.houston.hp.com ([15.201.24.20]:25767 "EHLO g4t0017.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059Ab0LHNyA (ORCPT ); Wed, 8 Dec 2010 08:54:00 -0500 Subject: Re: [06/44] numa: fix slab_node(MPOL_BIND) From: Lee Schermerhorn To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Eric Dumazet , Mel Gorman , Christoph Lameter In-Reply-To: <20101208041725.GB2291@suse.de> References: <20101208000640.115606851@clark.site> <1291777422.26147.70.camel@zaphod> <20101208041725.GB2291@suse.de> Content-Type: text/plain; charset="UTF-8" Organization: HP/LKTT Date: Wed, 08 Dec 2010 08:54:27 -0500 Message-ID: <1291816467.3941.19.camel@zaphod> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2291 Lines: 58 On Tue, 2010-12-07 at 20:17 -0800, Greg KH wrote: > On Tue, Dec 07, 2010 at 10:03:42PM -0500, Lee Schermerhorn wrote: > > On Tue, 2010-12-07 at 16:04 -0800, Greg KH wrote: > > > 2.6.27-stable review patch. If anyone has any objections, please let us know. > > > > > > ------------------ > > > > > > From: Eric Dumazet > > > > > > commit 800416f799e0723635ac2d720ad4449917a1481c upstream. > > > > > > When a node contains only HighMem memory, slab_node(MPOL_BIND) > > > dereferences a NULL pointer. > > > > > > [ This code seems to go back all the way to commit 19770b32609b: "mm: > > > filter based on a nodemask as well as a gfp_mask". Which was back in > > > April 2008, and it got merged into 2.6.26. - Linus ] > > > > > > Signed-off-by: Eric Dumazet > > > Cc: Mel Gorman > > > Cc: Christoph Lameter > > > Cc: Lee Schermerhorn > > > Cc: Andrew Morton > > > Signed-off-by: Linus Torvalds > > > Signed-off-by: Greg Kroah-Hartman > > > > > > --- > > > mm/mempolicy.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- a/mm/mempolicy.c > > > +++ b/mm/mempolicy.c > > > @@ -1404,7 +1404,7 @@ unsigned slab_node(struct mempolicy *pol > > > (void)first_zones_zonelist(zonelist, highest_zoneidx, > > > &policy->v.nodes, > > > &zone); > > > - return zone->node; > > > + return zone ? zone->node : numa_node_id(); > > > > I think this should be numa_mem_id(). Given the documented purpose of > > slab_node(), we want a node from which page allocation is likely to > > succeed. numa_node_id() can return a memoryless node for, e.g., some > > configurations of some HP ia64 platforms. numa_mem_id() was introduced > > to return that same node from which "local" mempolicy would allocate > > pages. > > So should the upstream patch be changed? > Yeah, probably should. I didn't see it go by. Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/