Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755698Ab0LHPVy (ORCPT ); Wed, 8 Dec 2010 10:21:54 -0500 Received: from claw.goop.org ([74.207.240.146]:43485 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755285Ab0LHPVx (ORCPT ); Wed, 8 Dec 2010 10:21:53 -0500 Message-ID: <4CFFA28E.5030805@goop.org> Date: Wed, 08 Dec 2010 07:21:50 -0800 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 MIME-Version: 1.0 To: Borislav Petkov CC: Ian Campbell , Greg KH , "Roedel, Joerg" , "linux-kernel@vger.kernel.org" , "stable@kernel.org" , "H. Peter Anvin" Subject: Re: [PATCH 1/3] x86-32: Separate 1:1 pagetables from swapper_pg_dir References: <20101111141358.GA4641@kroah.com> <1289488576-18117-2-git-send-email-joerg.roedel@amd.com> <20101207210512.GA14849@kroah.com> <4CFEF637.4020203@goop.org> <20101208041528.GA2211@kroah.com> <1291800855.13966.4404.camel@zakaz.uk.xensource.com> <20101208115806.GA11716@aftab> In-Reply-To: <20101208115806.GA11716@aftab> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 32 On 12/08/2010 03:58 AM, Borislav Petkov wrote: > On Wed, Dec 08, 2010 at 04:34:15AM -0500, Ian Campbell wrote: >> On Wed, 2010-12-08 at 04:15 +0000, Greg KH wrote: >>> On Tue, Dec 07, 2010 at 07:06:31PM -0800, Jeremy Fitzhardinge wrote: >>>> On 12/07/2010 01:05 PM, Greg KH wrote: >>>>> On Thu, Nov 11, 2010 at 04:16:14PM +0100, Joerg Roedel wrote: >>>>>> commit fd89a137924e0710078c3ae855e7cec1c43cb845 upstream >>>>> applied, thanks. >>>> This will need as well 5b5c1af104ab5adec1be9dcb4c787492d83d8d83 to >>>> prevent Xen regressions. >>> So should I add that to a specific release? The next .36 stable or something else? >> 5b5c1af104ab5 fixed an issue exposed by b40827fa7268. I'm not sure if >> fd89a13792 also exposes a similar issue, but I think it does not: >> >> It looks to me like fd89a13792 only reads from swapper_pg_dir and writes >> to trampoline_pg_dir which is unpinned (and unused) under Xen and hence >> there is no problem and 5b5c1af104ab5 is not needed. > I tend to agree with Ian's assessment here. > > Let me put it this way: have you guys seen any Xen-related regressions > with fd89a13792? I mean, this patch went in after 2.6.36-rc1 and if > it were breaking Xen, we (or maybe you :)) would've caught it by now, > right? No, I got confused. Sorry for spreading the confusion around... J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/