Subject: Re: [PATCH] syslog: check cap_syslog when dmesg_restrict
From: Eric Paris <eparis@redhat.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: James Morris <jmorris@namei.org>, Stephen Smalley <sds@tycho.nsa.gov>,
        dwalsh@redhat.com, Kees Cook <kees.cook@canonical.com>,
        linux-kernel@vger.kernel.org
In-Reply-To: <20101208164235.GA21062@mail.hallyn.com>
References: <20101208151901.GA20557@mail.hallyn.com>
	 <1291822780.3072.40.camel@localhost.localdomain>
	 <20101208164235.GA21062@mail.hallyn.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 08 Dec 2010 11:46:23 -0500
Message-ID: <1291826783.3072.41.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 825
Lines: 26

On Wed, 2010-12-08 at 16:42 +0000, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@redhat.com):

> >   I think the code might be
> > incorrect today as well......
> > 
> > I thought the flow was supposed to be
> > 
> > if (capable(CAP_SYSLOG))
> > 	all good
> > else if (capable(CAP_SYS_ADMIN))
> > 	WARN, but still good for now
> 
> I prefer warn and deny.  Otherwise it's too easy to ignore warnings.  So
> I prefer the msg to be there to explain why it failed - not that I expect
> it to fail for anyone today.

Ok, fine with me.

Acked-by: Eric Paris <eparis@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/