Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199Ab0LHWVO (ORCPT ); Wed, 8 Dec 2010 17:21:14 -0500 Received: from smtp.outflux.net ([198.145.64.163]:38338 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754303Ab0LHWVL (ORCPT ); Wed, 8 Dec 2010 17:21:11 -0500 Date: Wed, 8 Dec 2010 14:19:51 -0800 From: Kees Cook To: mat Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-next@vger.kernel.org, Arjan van de Ven , James Morris , Andrew Morton , Andi Kleen , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Rusty Russell , Stephen Rothwell , Dave Jones , Siarhei Liakh Subject: Re: [PATCH 3/3 V13] RO/NX protection for loadable kernel Message-ID: <20101208221951.GO5750@outflux.net> References: <4CE2F914.9070106@free.fr> <24422.1290656467@localhost> <20101126182355.62615dff@mat-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101126182355.62615dff@mat-laptop> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 39 On Fri, Nov 26, 2010 at 06:23:55PM +0100, mat wrote: > could you try the attached patch ? > > on module load, we sort the __jump_table section. So we should make it > writable. > > > Matthieu > diff --git a/arch/x86/include/asm/jump_label.h b/arch/x86/include/asm/jump_label.h > index f52d42e..574dbc2 100644 > --- a/arch/x86/include/asm/jump_label.h > +++ b/arch/x86/include/asm/jump_label.h > @@ -14,7 +14,7 @@ > do { \ > asm goto("1:" \ > JUMP_LABEL_INITIAL_NOP \ > - ".pushsection __jump_table, \"a\" \n\t"\ > + ".pushsection __jump_table, \"aw\" \n\t"\ > _ASM_PTR "1b, %l[" #label "], %c0 \n\t" \ > ".popsection \n\t" \ > : : "i" (key) : : label); \ Acked-by: Kees Cook Can this please get committed to tip? Thanks, -Kees -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/