Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100Ab0LHWZV (ORCPT ); Wed, 8 Dec 2010 17:25:21 -0500 Received: from mail-iw0-f172.google.com ([209.85.214.172]:47483 "EHLO mail-iw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406Ab0LHWZS (ORCPT ); Wed, 8 Dec 2010 17:25:18 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=VNxyED5qEIFnNYb205WSOxx/0AuZYby2iOU1dNzoiJEsRvKU4aaqP0/KmFXUgeiBfO 5wftXE0WTlJ6k+vwPIN6X2u9cjLwHamNJqyyVei9GqXF3vdVnx8jdrUE+cNR8qAdAf5q k0UGrGpa67XEW5ioJrbCJsw9DmNGkESajy1xs= MIME-Version: 1.0 In-Reply-To: <20101208164327.GL2356@cmpxchg.org> References: <1291734086-1405-1-git-send-email-minchan.kim@gmail.com> <20101208164327.GL2356@cmpxchg.org> Date: Thu, 9 Dec 2010 07:25:18 +0900 Message-ID: Subject: Re: [PATCH] compaction: Remove mem_cgroup_del_lru From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , linux-mm , LKML , Balbir Singh , KAMEZAWA Hiroyuki , Mel Gorman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 31 On Thu, Dec 9, 2010 at 1:43 AM, Johannes Weiner wrote: > On Wed, Dec 08, 2010 at 12:01:26AM +0900, Minchan Kim wrote: >> del_page_from_lru_list alreay called mem_cgroup_del_lru. >> So we need to call it again. It makes wrong stat of memcg and >> even happen VM_BUG_ON hit. >> >> Cc: Balbir Singh >> Cc: KAMEZAWA Hiroyuki >> Cc: Mel Gorman >> Signed-off-by: Minchan Kim > > Reviewed-by: Johannes Weiner > > But regarding the severity of this: shouldn't the second deletion > attempt be caught by the TestClearPageCgroupAcctLRU() early in > mem_cgroup_del_lru_list()? > Right, I missed that. Andrew, I will resend modified description. Thanks for careful review again, Hannes. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/